[TIMOB-26559] iOS: App crash and missing events for local notifications
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2018-11-15T22:02:38.000+0000 |
Affected Version/s | Release 7.4.1 |
Fix Version/s | Release 7.5.0 |
Components | iOS |
Labels | n/a |
Reporter | Jan Vennemann |
Assignee | Jan Vennemann |
Created | 2018-11-14T13:21:02.000+0000 |
Updated | 2018-11-19T21:56:02.000+0000 |
Description
There are currently multiple issues around local notifications which either crash the app, do not trigger an event at all, or trigger the wrong event. This ticket is used to group other related tickets and fix those issues all in one go as they all interfere with each other.
*Issue 1* (AC-5993)
Scheduling local notification raises a "unrecognized selector sent to instance" exception when the app is in foreground when the notification triggers. This was already fixed in TIMOB-26513. However, local notifications shouldn't even try to trigger this method meaning our logic in UNNotificationCenter delegates is flawed and needs to be fixed.
*Issue 2* (AC-6013 & AC-6015)
Local notifications are not scheduled (or appear so because no notification will be fired).
PR (master): https://github.com/appcelerator/titanium_mobile/pull/10468 PR (7_5_X): https://github.com/appcelerator/titanium_mobile/pull/10470
FR passed awaiting CRs and Jenkins to be ready.
PR's merged.
Verified the fix in 7.5.0.GA & 8.0.0.v20181119101552. Closing.