[TIMOB-26564] Windows: Cannot find module 'babylon' error thrown on build

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2018-11-16T01:00:23.000+0000
Affected Version/s	Release 8.0.0
Fix Version/s	Release 8.0.0
Components	CLI, Windows
Labels	n/a
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2018-11-15T13:10:35.000+0000
Updated	2018-11-20T21:58:51.000+0000

Description

When building for windows the following error is thrown, this is because of the changes made in TIMOB-25650. We can remove this code though as it is a backwards compat thing for hyperloop 2.x

Error: Cannot find module 'babylon'

    at Function.Module._resolveFilename (module.js:547:15)

    at Function.Module._load (module.js:474:25)

    at Module.require (module.js:596:17)

    at require (internal/module.js:11:18)

    at Object.<anonymous> (C:\ProgramData\Titanium\mobilesdk\win32\8.0.0.v20181114074027\windows\cli\commands\_build\copy.js:10:12)

    at Module._compile (module.js:652:30)

    at Object.Module._extensions..js (module.js:663:10)

    at Module.load (module.js:565:32)

    at tryModuleLoad (module.js:505:12)

    at Function.Module._load (module.js:497:3)

---------------------------------------------

    at C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\node-appc\node_modules\async\dist\async.js:2135:9

    at apply (C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\node-appc\node_modules\async\dist\async.js:21:25)

    at C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\node-appc\node_modules\async\dist\async.js:56:12

    at _insert (C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\node-appc\node_modules\async\dist\async.js:2248:9)

    at Object.push (C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\node-appc\node_modules\async\dist\async.js:2294:13)

    at Object.findExecutable (C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\node-appc\lib\subprocess.js:113:8)

    at resolveNode (C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\titanium\lib\titanium.js:97:34)

    at C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\titanium\lib\titanium.js:74:5

    at Object.<anonymous> (C:\Jenkins\workspace\anium_mobile_windows_master-VEBTVBGZKPOIHZSZQD5XUBDGPM6Q4OEDUIMQP6TH2EZSWDMRL22Q\titanium-mobile-mocha-suite\node_modules\titanium\lib\titanium.js:80:2)

Steps to reproduce

1. Build for Windows

Actual

Above error thrown

Expected

No error thrown

Attachments

File	Date	Size
hyperloop-3.2.0-windows.zip	2018-11-20T20:53:22.000+0000	2778282

Comments

Ewan Harris 2018-11-15

https://github.com/appcelerator/titanium_mobile_windows/pull/1322
Kota Iguchi 2018-11-16

Merged.
Kota Iguchi 2018-11-20

Just posted new hyperloop module so you can test this fix. [^hyperloop-3.2.0-windows.zip]

Keerthi Mahalingam 2018-11-20

Verified the fix with hyperloop-3.2.0 and sdk 8.0.0.v20181120090229. able to build app successfully on windows device

   Test Environment:
   Name                        = Microsoft Windows 10 Pro 
     Version                     = 10.0.17134 
     Architecture                = 64bit 
     Node.js 
     Node.js Version             = 8.9.1 
     npm Version                 = 5.5.1 
   Titanium CLI 
     CLI Version                 = 5.1.1 
   Titanium SDK 
     SDK Version                 = 8.0.0.v20181120090229 
   Device 
   Lumia 650 dual sim 
   Mobile emulator 10.0.14393 1080p

JSON Source