[TIMOB-26565] Windows: Building with hyperloop fails with "traverse is not a function"

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2018-11-16T02:06:47.000+0000
Affected Version/s	Release 8.0.0, Hyperloop 3.1.3
Fix Version/s	Release 8.0.0
Components	CLI, Hyperloop, Windows
Labels	n/a
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2018-11-15T13:39:08.000+0000
Updated	2018-11-20T21:54:57.000+0000

Description

Building hyperloop-examples with SDK 8 throws the following error. This is because hyperloop-examples is using the babel packages from within the SDK and these were removed in TIMOB-25650. The hyperloop hook should be fixed up to have its own dependencies

TypeError: traverse is not a function
    at WindowsBuilder.pre (C:\ProgramData\Titanium\modules\windows\hyperloop\3.1.3\hooks\hyperloop.js:97:5)
    at C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\lib\hook.js:214:10
    at C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:3845:9
    at replenish (C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:1030:17)
    at C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:1034:9
    at eachOfLimit (C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:1061:22)
    at C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:1066:16
    at _parallel (C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:3844:5)
    at Object.series (C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\node_modules\async\dist\async.js:4663:3)
    at C:\Users\awam\.appcelerator\install\7.0.7\package\node_modules\titanium\lib\hook.js:211:9
[ERROR] traverse is not a function

Steps to reproduce

1. Build hyperloop-examples

Actual

traverse is not a function is thrown

Expected

No error, app should build just fine

Attachments

File	Date	Size
hyperloop-3.2.0-windows.zip	2018-11-20T20:57:53.000+0000	2778282

Comments

Ewan Harris 2018-11-15

PR: https://github.com/appcelerator/hyperloop.next/pull/310 Waiting to see what happens with the build before putting into review properly
Kota Iguchi 2018-11-20

Just posted new hyperloop module so you can test this fix. [^hyperloop-3.2.0-windows.zip]

Keerthi Mahalingam 2018-11-20

Verfied the fix with hyperloop-3.2.0 and sdk 8.0.0.v20181120090229. Hyperloop example works fine.

   Test Environment:
   Name                        = Microsoft Windows 10 Pro 
     Version                     = 10.0.17134 
     Architecture                = 64bit 
     Node.js 
     Node.js Version             = 8.9.1 
     npm Version                 = 5.5.1 
   Titanium CLI 
     CLI Version                 = 5.1.1 
   Titanium SDK 
     SDK Version                 = 8.0.0.v20181120090229 
   Device 
   Lumia 650 dual sim 
   Mobile emulator 10.0.14393 1080p

JSON Source