[TIMOB-26612] Problem with Internationalization
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-12-18T14:58:24.000+0000 |
| Affected Version/s | Release 7.5.0 |
| Fix Version/s | Release 7.5.1 |
| Components | n/a |
| Labels | ios, locale, regression |
| Reporter | Thomas Weber |
| Assignee | Vijay Singh |
| Created | 2018-11-27T18:20:19.000+0000 |
| Updated | 2018-12-18T20:59:04.000+0000 |
Description
Ti.Locale.currentLanguage returns wrong language
Ti.Locale.currentLocale return correct language
Localized strings L("key") are replaced incorrectly
(Works fine with SDK 7.4.x)
Steps to reproduce:
1. Create strings.xml within folder i18n/de and add _deutsch _ into resources node. Create strings.xml within i18n/en folder and add _english _ into resources node.
2. Set simulator device language and region to "German"
3. Add lines to app.js:
console.log(Ti.Locale.currentLanguage);
console.log(Ti.Locale. Ti.Locale.currentLocale);
4. Add label with a localized string e. g. L("test") to view
*Expected results:*
Console:
de
de-DE
Label text:
deutsch
*Current results*:
Console:
en
de-DE
Label text:
english
This might be issue due to [this PR](https://github.com/appcelerator/titanium_mobile/pull/10227). Need to look in this.
PR(master)- https://github.com/appcelerator/titanium_mobile/pull/10499 Test Case 1- Test case mentioned TIMOB-13966. Test Case 2- After changing language in device/ simulator it should log proper value, as mentioned in this ticket.
var win = Ti.UI.createWindow({ backgroundColor: '#fff' }); var btn = Ti.UI.createButton({ title: 'Trigger' }); btn.addEventListener('click', function() { Ti.API.info(Ti.Locale.currentLanguage); Ti.API.info(Ti.Locale.currentLocale); }); win.add(btn); win.open();Closing ticket. Fix verified in SDK version
8.0.0.v20181207074202. Test and other information can be found at: https://github.com/appcelerator/titanium_mobile/pull/10499[~lchoudhary] PR (7_5_X) - https://github.com/appcelerator/titanium_mobile/pull/10545
*FR Passed 7_5_X*
Verified the fix in SDK 7.5.1.v20181218070137. Closing.