[TIMOB-26668] iOS: Using ScrollView without RefreshControl breaks build

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2018-12-20T11:30:18.000+0000
Affected Version/s	n/a
Fix Version/s	Release 8.0.0
Components	iOS
Labels	qe-testadded
Reporter	Jan Vennemann
Assignee	Jan Vennemann
Created	2018-12-19T19:41:32.000+0000
Updated	2019-04-24T22:45:24.000+0000

Description

Using Ti.UI.ScrollView without Ti.UI.RefreshControl breaks the build. *Steps to reproduce the behavior* * Use the following code in a classic app to create a basic scroll view:

const win = Ti.UI.createWindow();
const scrollView = Ti.UI.createScrollView({
  height: '80%',
  width: '80%'
});
const view = Ti.UI.createView({
  backgroundColor:'#336699',
  borderRadius: 10,
  top: 10,
  height: 2000,
  width: 1000
});
scrollView.add(view);
// Uncomment this to fix the build
//const refreshControl = Ti.UI.createRefreshControl();
//scrollView.refreshControl = refreshControl;
win.add(scrollView);
win.open();

* Build and run the app for iOS device or simulator *Actual behavior* Building the app fails with the following error:

[TRACE] /Users/jvennemann/Development/appc/hyperloop-examples/build/iphone/Classes/TiUIScrollView.m:367:3: error: expected expression
[TRACE]   ENSURE_SINGLE_ARG_OR_NIL(args, TiUIRefreshControlProxy);
[TRACE]   ^
[TRACE] In module 'TitaniumKit' imported from /Users/jvennemann/Development/appc/hyperloop-examples/build/iphone/Classes/TiUIScrollView.h:15:
[TRACE] Frameworks/TitaniumKit.framework/Headers/TiBase.h:158:15: note: expanded from macro 'ENSURE_SINGLE_ARG_OR_NIL'
[TRACE]       x = (t *)[x objectAtIndex:0];                                                                                                                                          \
[TRACE]               ^
[TRACE] /Users/jvennemann/Development/appc/hyperloop-examples/build/iphone/Classes/TiUIScrollView.m:367:34: error: use of undeclared identifier 'TiUIRefreshControlProxy'

*Expected behavior* The build should run without any errors. *Additional notes* This was introduced by https://github.com/appcelerator/titanium_mobile/pull/10103

Comments

Jan Vennemann 2018-12-19

PR: https://github.com/appcelerator/titanium_mobile/pull/10550
Samir Mohammed 2019-01-02

Closing ticket. Fix verified in SDK version: 8.0.0.v20181224175014. Test and other information can be found at: https://github.com/appcelerator/titanium_mobile/pull/10550

JSON Source