[TIMOB-26704] LiveView: Transpilation does not work if not set in tiapp

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2019-01-09T18:44:02.000+0000
Affected Version/s	Release 8.0.0
Fix Version/s	Release 8.0.0, liveview 1.4.1
Components	LiveView
Labels	n/a
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2019-01-08T15:17:21.000+0000
Updated	2019-01-11T11:48:04.000+0000

Description

LiveView pulls whether it should transpile from the tiapp which was fine while it was opt-in (but it was still a bad thing), now it's opt-out the method needs to be updated.

Steps to reproduce

1. Run kitchensink-v2 with liveview and transpile removed from the tiapp to ios (you'll probably hit TIMOB-26649, just follow the workaround)

Actual

Error like below due to not transpiling

[ERROR] SyntaxError: Unexpected identifier 'ActionBarHelper'. import call expects exactly one argument.
[ERROR] File: app
[ERROR] Line: 12
[ERROR] SourceId: <null>
[ERROR] Backtrace:
[ERROR]  undefined

Expected

No error

Comments

Ewan Harris 2019-01-08

LiveView PR: https://github.com/appcelerator/liveview/pull/122
Samir Mohammed 2019-01-11

Closing ticket. Verified fix in SDK version: 8.1.0.v20190110171519 and SDK version: 8.0.0.v20190110110255. Note studio version 5.1.2.201812191857 was also used.

JSON Source