[TIMOB-26770] iOS: Use Swift 5 by default
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2019-07-09T17:38:53.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 8.1.0 |
Components | iOS |
Labels | n/a |
Reporter | Hans Knöchel |
Assignee | Jan Vennemann |
Created | 2019-01-26T23:37:46.000+0000 |
Updated | 2019-08-08T09:32:31.000+0000 |
Description
iOS should use Swift 4.2 by default, especially as Swift 5 is ready to be released soon and currently Swift 3.1 (not forwards compatible) is used in module- and project-templates.
PR: https://github.com/appcelerator/titanium_mobile/pull/10830 SDK 8+ modules to test with: - https://github.com/appcelerator-modules/titanium-onboarding - https://github.com/prashantsaini1/titanium-imagepicker/
Updated to use Swift 5, which ships with Xcode 10.2.
Created https://github.com/appcelerator/titanium_mobile/pull/10974 that only includes the module template updates to speed things up. The warnings will then be addressed separately in TIMOB-27163.
[~jvennemann] Can you backport for 8_1_X please? Thanks!
8_1_X backport added: https://github.com/appcelerator/titanium_mobile/pull/10977
Did FR for 8_1_X PR and not able to test on master PR .[~jvennemann] please resolve the conflict on master PR
[~kmahalingam], the master PR for this is https://github.com/appcelerator/titanium_mobile/pull/10974, not the initial PR from Hans.
FR passed. PR merged on master and 8_1_X
Verified the fix on sdk 8.2.0.v20190709091225 and 8.1.0.v20190709083308. no error on build modules.Works as expected. Closing. Test Environment:
With this changes I'm still unable to see logs in my app
[~bgarcia], please see TIMOB-26861 for the logging issues in native modules.