Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-26789] android: Ti.Buffer#clone() will copy over null type/value properties to cloned Buffer when undefined on original

GitHub Issuen/a
TypeBug
PriorityLow
StatusClosed
ResolutionFixed
Resolution Date2019-03-27T15:26:02.000+0000
Affected Version/sRelease 8.0.0
Fix Version/sRelease 8.0.1
ComponentsAndroid
Labelsn/a
ReporterChristopher Williams
AssigneeChristopher Williams
Created2019-02-01T18:26:55.000+0000
Updated2019-03-27T15:26:02.000+0000

Description

Due to an updated shouldjs library, equality checks are stricter, exposing this bug where a clone Ti.Buffer will inherit null values for type/value when they're undefined on the original.

Comments

  1. Christopher Williams 2019-02-01

    8_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/10670 (already merged to master)
  2. Christopher Williams 2019-03-15

    merged to master/8_0_X
  3. Christopher Williams 2019-03-27

    Note that this really isn't something QE can easily test without writing a very specific unit test which already exists in our suite. I'm marking closed as this is an extremely trivial "bug" that is only exposed by cloning a Ti.Buffer and comparing two values using === vs ==.

JSON Source