[TIMOB-26804] Implement Padding property for all Views
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | None |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | n/a |
| Fix Version/s | n/a |
| Components | TiAPI |
| Labels | margin, padding |
| Reporter | Brenton House |
| Assignee | Unknown |
| Created | 2019-02-06T18:34:12.000+0000 |
| Updated | 2020-03-06T16:51:27.000+0000 |
Description
Add
Padding property to Ti.UI.View.
We currently have Padding for TextField and TextArea but not on View or most other controls.
Would you mind splitting this into 2 feature tickets please? One for padding support. The other for margin support. I'm less keen on implementing margin support *+at the moment+* since it involves mucking with our layout handling code on all platforms and has a much higher risk of breakage/regressions. *+Yes+*, this would be a great feature to add... but it literally took us years to get our layout handling in parity between platforms (the same was true with web browsers). Particularly when it comes to conflicting layout settings. I don't see us doing margin support in the "near" future. I'm not saying never. Just that "now" is not the time. _Note: You can implement your margin support by wrapping a view within a view and setting the left/top/right/bottom properties to the margins you want. Just be warned that Android has a limit to how deeply nested your view hierarchy can be and will refuse to render views that are too deep. (Nothing is ever easy.)_ Padding support should be easier to implement than margins, hence why the 2 features should be separate tickets. Just note that when it comes to labels/text, padding won't be pixel-perfect between platforms since each platform (iOS, Google, Windows) has completely different text rendering systems and text will appear slightly different between them. I know that the Chrome web browser gets around this by bundling its own text rendering library on all platforms to make text rendering consistent. We don't really have that option (text rendering libraries tend to be super huge). Anyways, that's my 2 cents. :) I'm just trying to set some realistic expectations.
[~jquick] - Done!
[~jquick] - Any way we can fit this into one of our upcoming releases?
[~amukherjee] Up to 52 likes for this feature on slack! :) https://ti-slack.slack.com/archives/C0B2EUWRK/p1582556990002600