[TIMOB-26834] Android: NavigationView root window displays back button
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2019-04-03T09:13:52.000+0000 |
Affected Version/s | Release 8.0.0 |
Fix Version/s | Release 8.0.1 |
Components | Android |
Labels | n/a |
Reporter | Rene Pot |
Assignee | Yordan Banev |
Created | 2019-02-18T11:26:01.000+0000 |
Updated | 2019-04-03T09:13:52.000+0000 |
Description
When creating a basic NavigationWindow in Android it displays a back button (see attachment) where it shouldn't, since it is the root window.
<NavigationWindow>
<Window class="container">
<Label id="label" onClick="doClick">Hello, World</Label>
</Window>
</NavigationWindow>
Basically, the hello world app with a wrapping NavigationWindow
*Expected result*
It should not display a back button on root window
Attachments
File | Date | Size |
---|---|---|
Screenshot_1550489020.png | 2019-02-18T11:25:51.000+0000 | 34484 |
PR: https://github.com/appcelerator/titanium_mobile/pull/10710
I can confirm my test case is now working with this PR
This sounds like a major parity issue. We should probably make this change in 8.0.0.GA too.
We talked with [~topener] about it and agreed on the same - it will be good to have it in 8.0.0.GA. I will create a backport.
Yep, it basically is a bug in the implementation of NavigationWindow on Android. So for sure 8.0
I have missed to backport this for the GA release of 8.0.0, but lets get it into 8.0.1. PR (8_0_X): https://github.com/appcelerator/titanium_mobile/pull/10791
FR Passed, Waiting on Jenkins builds.
*Closing ticket* Fix verified in SDK Version
8.0.1.v20190402094527
and SDK Version8.1.0.v20190402113644
Test and other information can be found at: Master: https://github.com/appcelerator/titanium_mobile/pull/10710 8_0_X: https://github.com/appcelerator/titanium_mobile/pull/10791