[TIMOB-26985] iOS: Native modules are not protected
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-05-08T16:54:41.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.0.1 |
| Components | iOS |
| Labels | n/a |
| Reporter | Gary Mathews |
| Assignee | Gary Mathews |
| Created | 2019-04-16T00:51:39.000+0000 |
| Updated | 2019-05-12T22:35:31.000+0000 |
Description
- Native modules are not protected from deallocation by JavascriptCore. This means cached modules can have their proxies released.
Super interesting! Is this causing TIMOB-26852 internally? Let me know if I can test internally.
aca: https://github.com/appcelerator-modules/appcelerator.aca/pull/17
master: https://github.com/appcelerator/titanium_mobile/pull/10855
[~vijaysingh] [~smohammed] Do you know if this is also the ultimate fix for TIMOB-26852?
[~hknoechel] 1. We are going to test this PR in issue mentioned in TIMOB-26852. And 2. This PR in conjunction with the PR in TIMOB-26852 and let you know. If you can try at your end as well , will be great. Thanks!
PR(8_0_X) - https://github.com/appcelerator/titanium_mobile/pull/10859
merged to master
FR Passed. PR's Merged.
We are seeing hang on splash after a large period of time. This PR has reduced the incidence rate, but it is still happening. There is no crash just a hang on splash. Not sure how I can help with no crash log to provide, but wanted the team to know that there appears to be an issue still.
Further to last comment we have solved the hang by removing the ti.worker module from our project. It appears there maybe a problem with that module and this SDK.