[TIMOB-27090] iOS: Using a non-string value in alert() causes app to crash in SDK 8.0.0+

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2019-06-10T19:25:21.000+0000
Affected Version/s	n/a
Fix Version/s	Release 8.1.0
Components	iOS
Labels	n/a
Reporter	Hans Knöchel
Assignee	Christopher Williams
Created	2019-05-19T12:11:25.000+0000
Updated	2019-06-10T19:25:21.000+0000

Description

When using a non-string value like an object, the app crashes. This is a regression from moving to TitaniumKit and was caused by using the UIAlertController in the AlertCallback method directly instead of the TiUiAlertDialog proxy.

Comments

Hans Knöchel 2019-05-19

Pull: https://github.com/appcelerator/titanium_mobile/pull/10901
Satyam Sekhri 2019-05-23

FR passed. The computed alert message is converted to string and then displayed in alert. No app crash or issues with message shown in alert noticed. Verified on: Mac OS:10.14.3 Ti SDK: 8.1.0.v20190523110359 Appc CLI: 7.0.11 XCode: 10.2.1

Keerthi Mahalingam 2019-06-10

Verified the fix on SDK 8.1.0.v20190606063903 and 8.2.0.v20190606063615 .NO crashing on showing alert .works as expected

    Name                        = Mac OS X
     Version                     = 10.13.6
     Architecture                = 64bit
     # CPUs                      = 8
     Memory                      = 17179869184
   Node.js
     Node.js Version             = 8.9.1
     npm Version                 = 5.5.1
   Titanium CLI
     CLI Version                 = 5.1.1
   Titanium SDK
     SDK Version                 = 8.1.0.v20190606063903, 8.2.0.v20190606063615
   CLI =7.0.11
   Device =iPhone 6s plus iOS 12
   Simulator = Iphone XR IOS 12

JSON Source