[TIMOB-27097] iOS: Incremental builds fail to install app when using dynamic frameworks
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2019-08-28T22:58:12.000+0000 |
Affected Version/s | Release 8.0.1 |
Fix Version/s | Release 8.1.1 |
Components | iOS |
Labels | n/a |
Reporter | Jan Vennemann |
Assignee | Jan Vennemann |
Created | 2019-05-22T21:17:24.000+0000 |
Updated | 2019-08-28T22:58:12.000+0000 |
Description
If a framework contains .png or .plist files our build will try to optimize those. Xcode will update code signing on the first build but fails to do so on subsequent builds. Frameworks should be left untouched to avoid this issue.
*Steps to reproduce the behavior*
Place any framework containing PNG files into
Place any framework containing PNG files into platform/ios
(https://github.com/cjwirth/RichEditorView for example)
Build and run the app for device
Repeat!
*Actual behavior* On incremental builds the app fails to install with the following error:
[ERROR] An error occurred during build after 6s 579ms
[ERROR] Failed to install app on device (0xe8008001)
[ERROR] For some reason the app failed to install on the device. Try reconnecting your device and check your provisioning profile and entitlements.
*Expected behavior*
The app can be installed as usual even on subsequent builds.
https://github.com/appcelerator/titanium_mobile/pull/10905
FR Passed. The project with a framework having png/plist files builds successfully each time.
Note that this was merged to master (for 8.2.0), but the PR is still up for 8.1.1 (and I assume is awaiting the 8.1.0 release going out first).
[~lchoudhary] per [~cwilliams] comment, the merge to 8_1_X was waiting for 8.1.0 to go out, can this one be merged to 8_1_X now?
[~ssekhri], Can you please look at this for 8.1.1.
8_1_X PR: https://github.com/appcelerator/titanium_mobile/pull/10996
FR Passed for 8_1_X PR. The project with a framework having png/plist files builds successfully each time.
Verified on: Mac OS 10.14.6 Ti SDK: 8.1.1.v20190828100656, 8.2.0.v20190828134315, 8.3.0.v20190828100616 Appc CLI: 7.1.1-5 Node: 10.5.0 JDK: 10.0.2 Xcode: 10.1 Studio: 5.1.3.201907112159 Device: iPhone 7Plus(v12.3)