[TIMOB-27127] iOS 13 : Expose new APIs to support Apple login
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-09-04T21:36:19.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.2.0 |
| Components | n/a |
| Labels | n/a |
| Reporter | Vijay Singh |
| Assignee | Vijay Singh |
| Created | 2019-06-03T23:50:07.000+0000 |
| Updated | 2019-09-04T21:36:19.000+0000 |
Description
Expose new APIs to support Apple login.
Working module: https://github.com/hansemannn/titanium-apple-sign-in
Great work [~hknoechel]!
PR (doc) - https://github.com/appcelerator-modules/titanium-apple-sign-in/pull/3
That PR has been merged. We'll need to push a release on to Github (or somewhere!) when we're ready and then update the SDK to point at it to get bundled in our master builds.
Pre-released v1.1.0 on Github.
Opened a PR to bundle it with the SDK: https://github.com/appcelerator/titanium_mobile/pull/11186
We should close my source repo and move it completely to the appc one. To retain stars / followers of the source repo, I would suggest to (once) transfer it officially through the settings and then sync it to only have one module. Otherwise I feel like we'll have trouble if I continue to curate my fork. Let me know!
[~hknoechel] I created a PR to merge back our changes to your original repo. I don't have rights to do the transfer from your repo.
Please delete the fork, then I can initiate the transfer!
FR, Passed. Waiting on Jenkins build. Will be merged into 8_3_X at a later date.
Merged to master for 8.2.0
Verified the fix on sdk 8.2.0.v20190904080637. Apple SignIn module is bundled with sdk and able to sign in with Apple ID.
Name = Mac OS X Version = 10.14.5 Architecture = 64bit Node.js Node.js Version = 10.16.2 npm Version = 6.9.0 Titanium CLI CLI Version = 5.2.1 Titanium SDK SDK Version = 8.2.0.v20190904080637 Device =iPhone XR iOS 13 Simulator-iphone 8plus iOS 13