[TIMOB-27185] Windows: Add VideoPlayer "scalingMode" constants VIDEO_SCALING_RESIZE_*
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | High |
Status | Closed |
Resolution | Hold |
Resolution Date | 2020-02-06T10:03:20.000+0000 |
Affected Version/s | Release 8.0.0 |
Fix Version/s | n/a |
Components | Windows |
Labels | VideoPlayer, parity, scaling, video |
Reporter | Joshua Quick |
Assignee | Samir Mohammed |
Created | 2019-06-26T06:59:08.000+0000 |
Updated | 2020-02-06T10:03:38.000+0000 |
Description
*Summary:*
As of Titanium 7.0.0, we've added the following iOS-only
Ti.Media.ViewPlayer
constants. We need to add them to Windows as well for parity.
* [Ti.Media.VIDEO_SCALING_RESIZE](https://docs.appcelerator.com/platform/latest/#!/api/Titanium.Media-property-VIDEO_SCALING_RESIZE)
* [Ti.Media.VIDEO_SCALING_RESIZE_ASPECT](https://docs.appcelerator.com/platform/latest/#!/api/Titanium.Media-property-VIDEO_SCALING_RESIZE_ASPECT)
* [Ti.Media.VIDEO_SCALING_RESIZE_ASPECT_FILL](https://docs.appcelerator.com/platform/latest/#!/api/Titanium.Media-property-VIDEO_SCALING_RESIZE_ASPECT_FILL)
*Note:*
The above constants were added to iOS via [TIMOB-19040].
https://github.com/appcelerator/titanium_mobile_windows/pull/1414
FR Passed, can be merged once Jenkins is ready.
*Closing ticket*, Fix verified in SDK version
9.0.0.v20191207023738
*Test and other information an be found at:* https://github.com/appcelerator/titanium_mobile_windows/pull/1414