Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-27195] iOS: Using a commonjs module in an itemtemplate fails in a classic app

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2019-09-02T11:17:57.000+0000
Affected Version/sRelease 8.0.2
Fix Version/sRelease 8.2.0
ComponentsiOS
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2019-06-28T12:10:48.000+0000
Updated2020-12-11T07:38:01.000+0000

Description

Description

When using a commonjs module as in an ItemTemplate the file fails to get required as it tries alloy first which throws an error, and then the classic code require is never executed, we need to nest the try catches to allow moving on

Steps to reproduce

1. Get https://github.com/ewanharris/ti.imageview-listview-example 2. Build to iOS

Actual

Error is thrown

Expected

No error thrown

Comments

  1. Ewan Harris 2019-06-28

    https://github.com/appcelerator/titanium_mobile/pull/11008
  2. Samir Mohammed 2019-08-22

    FR Passed, waiting on Jenkins build. [~eharris] Please could you provide a PR for 8_3_X.
  3. Ewan Harris 2019-08-22

    8_3_X: https://github.com/appcelerator/titanium_mobile/pull/11167
  4. Samir Mohammed 2019-08-28

    FR Passed on 8_3_X. Waiting on Jenkins.
  5. Christopher Williams 2019-08-29

    merged to master (8.2.0) and 8_3_X
  6. Samir Mohammed 2019-09-02

    *Closing ticket*, fix verified in SDK version 8.2.0.v20190829124255 and SDK version 8.3.0.v20190829124521. *Test and other information can be found at:* https://github.com/appcelerator/titanium_mobile/pull/11008 8_3_X: https://github.com/appcelerator/titanium_mobile/pull/11167

JSON Source