Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-27203] iOS: no apiversion validation performed on application build

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2019-07-05T13:55:37.000+0000
Affected Version/sRelease 8.1.0, Release 8.2.0
Fix Version/sRelease 8.1.0
ComponentsCLI, iOS
LabelsengSchedule, regression
ReporterEwan Harris
AssigneeEwan Harris
Created2019-07-02T13:56:59.000+0000
Updated2019-07-05T13:55:37.000+0000

Description

Description

When building for iOS there is no module apiversion validation being performed, this is because the apiversion in the SDK is stored as iphone, and node-appc is looking for ios.

Steps to reproduce

1. Add the following module to your tiapp modules section <module platform="iphone" version="1.1.0">com.appcelerator.aca</module> 2. Open the manifest file (probably at /Users/eharris/Library/Application Support/Titanium/modules/iphone/com.appcelerator.aca/1.1.0/manifest) 3. Change the apiversion to anything other than 2 4. Build with ti build -p ios --build-only

Actual

Build carries on past the module verification stage

Expected

Build should error that module is incompatible

Comments

  1. Ewan Harris 2019-07-02

    This is a regression in 8.1.0 due to the linked ticket so it should go into 8.1.0
  2. Ewan Harris 2019-07-02

    node-appc PR: https://github.com/appcelerator/node-appc/pull/171
  3. Ewan Harris 2019-07-03

    master: https://github.com/appcelerator/titanium_mobile/pull/11025 8_1_X: https://github.com/appcelerator/titanium_mobile/pull/11026
  4. Samir Mohammed 2019-07-04

    FR Passed.
  5. Samir Mohammed 2019-07-05

    *Closing ticket* Fix verified in SDK Version 8.2.0.v20190704101620 and 8.1.0.v20190704101545. *Test and other information can be found at:* master: https://github.com/appcelerator/titanium_mobile/pull/11025 8_1_X: https://github.com/appcelerator/titanium_mobile/pull/11026

JSON Source