[TIMOB-27250] Add Node 8 deprecation warning for SDK 9.0 release
| GitHub Issue | n/a |
|---|---|
| Type | Story |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-07-19T19:07:41.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.1.0 |
| Components | CLI |
| Labels | n/a |
| Reporter | Abir Mukherjee |
| Assignee | Christopher Williams |
| Created | 2019-07-17T16:27:47.000+0000 |
| Updated | 2020-02-10T21:37:32.000+0000 |
Description
Node 8 will not be supported in SDK 9.0. Please add a deprecation warning to the CLI in the next release.
There is some uncertainty as to where/how this will be done (I thought the belief was a warning in the appcelerator cli but I could be wrong), we can move this ticket if needed. My belief is we will want to log this out from the appc cli we will want to apply this restriction to the appc cli also. However there is some uncertainty as to whether this is just restricted to people running commands from Titanium SDK 8 (I would say this warning is relevant to _anyone_ using Titanium as I would imagine someday they'll have to use SDK 9 so it should be output always) There is also uncertainty as to when to output it i.e only on certain commands (I would say we output this always to increase the frequency of people seeing it) I think if Titanium SDK 7.5.2 (our only supported SDK in the 7.X line) works with Node 10, we should output all the time on every command either from the Titanium CLI or the Appcelerator CLI. I guess cc [~cbarber] [~cwilliams] and [~emerriman] for some clarification
After giving this some thought, I don't think we need to add a Node.js deprecation warning to the CLI. It complicates which CLI, which commands, which output method, which SDK, etc that the warning should be displayed. Instead, I propose the following:
Create a generic mechanism in the Titanium CLI (not the Appc CLI) that reads the SDK's
package.jsonand validate the current Node.js version against the"engine"Node version. If the check fails, then the command (build/clean/create/project) errors with a useful error message.Put the actual Node.js 8.x deprecation notice in the next CLI(s) and SDK release notes AND a dedicated blog post
** Appc CLI 7.1.0, Titanium CLI 5.x, and Titanium SDK 8.1.0 release notes state that SDK 9 will require Node 10 (though technically 8.12) or newerhttps://github.com/appcelerator/titanium_mobile/pull/11063
merged to 8_1_X and master branches
Verified the fix with SDK 8.1.0.v20190720135905. Closing.