[TIMOB-27519] Android: Semantic Colors with alpha value
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2020-05-26T17:31:52.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 9.1.0 |
Components | n/a |
Labels | android, darkmode, engSchedule, parity |
Reporter | Michael Gangolf |
Assignee | Christopher Williams |
Created | 2019-09-21T17:54:43.000+0000 |
Updated | 2020-08-25T00:41:08.000+0000 |
Description
Attachments
File | Date | Size |
---|---|---|
0001-fix-android-semantic-colors-with-alpha-value.patch | 2019-10-10T09:53:12.000+0000 | 2504 |
Are you sure it doesn't use the alpha value? This works for us:
Ti.UI.fetchSemanticColor() on Android (and I assume iOS < 13) returns only
"color"
, and is loosing the"alpha"
: https://github.com/appcelerator/titanium_mobile/blob/3b925d3b89e0d59bf89b846bfa127e9656746dbf/common/Resources/ti.internal/extensions/ti/ti.ui.js#L55 To fix it, I put this code into my alloy.js (based on [iphone/cli/commands/_build.js#generateSemanticColors](https://github.com/appcelerator/titanium_mobile/blob/3b925d3b89e0d59bf89b846bfa127e9656746dbf/iphone/cli/commands/_build.js#L5802)):I attached patch for the SDK with fix for this issue. Will send a PR after the ticket is approved (don't like commits without reference to ticket).
Hello [~s.volkov], Please share the PR here. Moving to TIMOB.
https://github.com/appcelerator/titanium_mobile/pull/11315
https://github.com/appcelerator/titanium_mobile/pull/11315
merged to master for 9.1.0 target