[TIMOB-27521] Android: Proxy more NotificationManager functions
GitHub Issue | n/a |
---|---|
Type | New Feature |
Priority | n/a |
Status | Open |
Resolution | Unresolved |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | Android |
Labels | android-8 |
Reporter | Emily Feder |
Assignee | Unknown |
Created | 2019-10-15T14:35:09.000+0000 |
Updated | 2019-11-06T16:54:22.000+0000 |
Description
I would like to be able to access android's [NotificationManager.deleteNotificationChannel](https://developer.android.com/reference/android/app/NotificationManager#deleteNotificationChannel(java.lang.String)),[NotificationManager.deleteNotificationChannelGroup](https://developer.android.com/reference/android/app/NotificationManager#deleteNotificationChannelGroup(java.lang.String)), and [NotificationManager.getNotificationChannels](https://developer.android.com/reference/android/app/NotificationManager#getNotificationChannels()) via the titanium api.
I need the deleteNotificationChannel function to be able to implement the solution to [this issue](https://monzo.com/blog/2019/05/28/fixing-notifications-on-android).
Hello [~emilyafeder@gmail.com], Thanks for the ticket. Our engineers will look into it. Can you provide a PR on this? Thanks.
I don't have a PR for the change. I guess if it's not a priority for appcelerator to work on, I could take a look at making a contribution. I have never worked on the Titanium code base -- perhaps if you could point me to resources on how to do so?
[~emilyafeder@gmail.com] have a look at https://github.com/appcelerator/titanium_mobile/blob/754020ff2f97e0f3f8390e0f46bc631f4afa8c5a/android/modules/android/src/java/ti/modules/titanium/android/notificationmanager/NotificationManagerModule.java#L113 you could copy that and adopt it to the delete part. To build the SDK you can have a look here: https://github.com/appcelerator/titanium_mobile#building-locally
Thanks, that's very helpful.