[TIMOB-27601] Windows: remove analyzeJsFile hook from titanium_mobile & hyperloop code
| GitHub Issue | n/a |
|---|
| Type | Story |
|---|
| Priority | Medium |
|---|
| Status | Closed |
|---|
| Resolution | Hold |
|---|
| Resolution Date | 2020-02-11T11:40:59.000+0000 |
|---|
| Affected Version/s | Release 8.3.0 |
|---|
| Fix Version/s | n/a |
|---|
| Components | Windows |
|---|
| Labels | n/a |
|---|
| Reporter | Ewan Harris |
|---|
| Assignee | Ewan Harris |
|---|
| Created | 2019-11-14T13:43:47.000+0000 |
|---|
| Updated | 2020-02-11T11:41:04.000+0000 |
|---|
Description
Description
Windows uses a non standard hook in the hyperloop module which we currently patch around in the processjstask, we should try to remove that hook from hyperloop and use the standardized hook if possible
Comments
JSON Source
Relates to: https://github.com/appcelerator/titanium_mobile/pull/11334
[~kiguchi], I think this would be classed as a breaking change so we'd have to do it in 9?
[~eharris] Makes sense, it reminds me that we should remove analyzeJsFile hook from titanium_mobile (https://github.com/appcelerator/titanium_mobile/pull/11334) too in 9.0.0.
https://github.com/appcelerator/hyperloop.next/pull/328
https://github.com/appcelerator/titanium_mobile/pull/11392