[TIMOB-27649] iOS: Deprecate Status Bar style constants

GitHub Issue	n/a
Type	Improvement
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2020-05-27T12:18:21.000+0000
Affected Version/s	n/a
Fix Version/s	Release 9.1.0
Components	iOS
Labels	statusbar
Reporter	Vijay Singh
Assignee	Vijay Singh
Created	2019-12-11T22:24:06.000+0000
Updated	2020-05-27T12:18:21.000+0000

Description

Status bar style constants - Titanium.UI.iOS.StatusBar.GREY and Titanium.UI.iOS.StatusBar.GRAY are not supported. These properties are mapped with UIStatusBarStyleDefault. See [here](https://github.com/appcelerator/titanium_mobile/blob/8cdac1898091dd7020d458c4ef66a8d36cb41e7e/iphone/Classes/TiUIiOSStatusBarProxy.m#L16). Deprecate these properties.

Comments

Vijay Singh 2020-05-01

PR - https://github.com/appcelerator/titanium_mobile/pull/11678 Test Case -

   var win = Ti.UI.createWindow({
       backgroundColor: '#fff'
   });
   
   var btn = Ti.UI.createButton({
       title: 'Trigger'
   });
   
   btn.addEventListener('click', function() {
       Ti.API.info(Ti.UI.iOS.StatusBar.GREY);
       Ti.API.info(Ti.UI.iOS.StatusBar.GRAY);
   });
   
   win.add(btn);
   win.open();

On click of button it should log deprecation warning.

Christopher Williams 2020-05-04

merged to master for 9.1.0 target (mainly a doc change, but using the old constant should log a depreciation message at runtime).

Samir Mohammed 2020-05-27

FR Passed: Able to see the following deprecation message using the test case above.

   [WARN]   Ti.UI.iOS.StatusBar.GREY DEPRECATED in 9.1.0, in favor of Ti.UI.iOS.StatusBar.DEFAULT
   [WARN]   Ti.UI.iOS.StatusBar.GRAY DEPRECATED in 9.1.0, in favor of Ti.UI.iOS.StatusBar.DEFAULT

*Test environment*

   MacOS Catalina: 10.15.5 Beta
   Xcode: 11.4
   Java Version: 1.8.0_131
   Android NDK: 21.1.6273396-beta2
   Node.js: 10.16.3
   ""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
   iphone 8 13.4 sim

Samir Mohammed 2020-05-27

Closing ticket fix verified in SDK version 9.1.0.v20200526103723

JSON Source