Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-27714] Android: Add "Material Components" theme support

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2020-11-25T14:59:00.000+0000
Affected Version/sn/a
Fix Version/sRelease 9.3.0
ComponentsAndroid
Labels2020-Q4, android, material-theme, style, theme
ReporterJoshua Quick
AssigneeJoshua Quick
Created2020-01-09T22:28:44.000+0000
Updated2020-11-25T14:59:00.000+0000

Description

*Summary:* Titanium currently defaults to the "Theme.AppCompat" style. We should change the default style to "Theme.MaterialComponents.Bridge", which allows to support Google's material widget classes. Without this theme, these widgets will throw an exception since the material theme contains styles they need. https://www.material.io https://github.com/material-components/material-components-android Using the material "bridge" theme keeps the current "dark" AppCompat theme so that it won't be a breaking change for app developers. If developers want to use Google's other material themes, then they can set it via the <application/> element in the "tiapp.xml" file AndroidManfiest.xml section.

Comments

  1. Joshua Quick 2020-08-18

    PR (9.3.x): https://github.com/appcelerator/titanium_mobile/pull/11921
  2. Joshua Quick 2020-08-18

    PR (kitchensink-v2): https://github.com/appcelerator/kitchensink-v2/pull/53 PR (hyperloop-example): https://github.com/appcelerator/hyperloop-examples/pull/86 _*Note:* The above PR changes will work on Titanium 9.0.0 and higher. They do not depend on the Titanium SDK 9.3.0 PR._
  3. Samir Mohammed 2020-09-28

    FR Passed, waiting on Jenkins builds.
  4. Samir Mohammed 2020-11-25

    *Closing ticket*. Improvement verified in SDK version 9.3.0.v20201125050632. *Test and other information can be found at: *https://github.com/appcelerator/titanium_mobile/pull/11921

JSON Source