[TIMOB-27734] Fix Android to use DefaultIcon.png for generating missing icons
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | None |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | n/a |
| Fix Version/s | n/a |
| Components | n/a |
| Labels | android, cb-tooling, griffin-app, icons |
| Reporter | Brenton House |
| Assignee | Unknown |
| Created | 2020-01-23T16:08:44.000+0000 |
| Updated | 2020-04-01T08:59:28.000+0000 |
Description
Currently, there is a DefaultIcon.png and a DefaultIcon-ios.png in the project root directory. iOS uses the DefaultIcon-ios.png but I think Android uses something like /app/assests/android/appicon.png
Their should be a DefaultIcon-android.png file that is used by Android (if it exists) and the DefaultIcon.png should be the default fallback if either DefaultIcon-ios.png or DefaultIcon-android.png is missing.
This is definitely a bug/oversight. The Android build [calls](https://github.com/appcelerator/titanium_mobile/blob/c8f358dcdd50763fb509576ee635f626bc9ba069/android/cli/commands/_build.js#L870) the base Builder validate that [generates the list of defaultIcons](https://github.com/appcelerator/node-titanium-sdk/blob/3cfe4346ee87b67fd7da89c2d75a525c588a7c93/lib/builder.js#L143-L146). The problem is nowhere (as far as I can tell) does the Android build call
generateAppIcons()or referencethis.defaultIcons. The Android build should callgenerateAppIcons()with the appropriate destination whether that be in theresfolder or elsewhere.FWIW, the work got done and then reverted in TIMOB-19486