Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-27771] Android: Hyperloop builds fail if NDK not installed as of 9.0.0

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2020-02-25T18:40:29.000+0000
Affected Version/sRelease 9.0.0, Hyperloop 5.0.0
Fix Version/sRelease 9.0.0
ComponentsAndroid, Hyperloop
Labelsandroid, hyperloop, ndk, regression
ReporterEwan Harris
AssigneeEwan Harris
Created2020-02-19T16:51:34.000+0000
Updated2020-02-25T18:40:29.000+0000

Description

_(This issue was caught before 9.0.0.GA.)_

Description

When building a hyperloop application without an NDK installed the build errors with the below, we just need to do a defensive check when we're looking up the ndk path 
[ERROR] TypeError: Cannot read property 'path' of null
    at HyperloopAndroidBuilder.build (/Users/awam/Library/Application Support/Titanium/modules/android/hyperloop/5.0.0/hooks/hyperloop.js:127:106)

Steps to reproduce

1. Move your NDK away from the usual location (~/Library/Android/sdk/ndk/) so the CLI doesn't autodetect and remove it from the config with {{appc ti config --remove android.ndkPath 2. Build the hyperloop-examples app

Actual

Above error

Expected

No error

Comments

  1. Ewan Harris 2020-02-19

    PR (hyperloop.next): https://github.com/appcelerator/hyperloop.next/pull/333
  2. Joshua Quick 2020-02-19

    I merged above PR a little too quickly. It requires the below changes as well. PR (hyperloop.next): https://github.com/appcelerator/hyperloop.next/pull/335
  3. Joshua Quick 2020-02-20

    PR (master): https://github.com/appcelerator/titanium_mobile/pull/11486 PR (9.0.x): https://github.com/appcelerator/titanium_mobile/pull/11487
  4. Lokesh Choudhary 2020-02-24

    FR Passed. PR's Merged.
  5. Lokesh Choudhary 2020-02-25

    Verified the fix with SDK 9.0.0.v20200224113949. Closing.

JSON Source