[TIMOB-27933] LiveView: Do not report disconnect errors to ACA
GitHub Issue | n/a |
Type | Improvement |
Priority | None |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2020-06-27T21:55:20.000+0000 |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | LiveView |
Labels | n/a |
Reporter | Ewan Harris |
Assignee | Gary Mathews |
Created | 2020-06-03T19:05:35.000+0000 |
Updated | 2020-06-27T21:55:25.000+0000 |
Description
Description
Currently when the liveview app code can't connect to the server it will spam errors (this will be improved in 9.1.0), however we should make sure that these errors also are not reported to ACA.
LiveView currently has a shim that overrides the old APM module that would make the functions a no-op, although I think that is too brute forcey. I think we are best to maybe try to suppress these errors somehow (probably by just handling them better), and then lastly trying to detect the error somehow in liveview and suppress if it is a liveview. (maybe we could prefix all errors with LIVEVIEW and check for that before sending onto ACA)
Comments
JSON Source
https://github.com/appcelerator-modules/appcelerator.aca/pull/32