[TIMOB-27934] Android: Update "ti.playservices" module to use 17.5.0
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Low |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2020-11-23T21:44:22.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 9.3.0 |
Components | Android |
Labels | android, module, ti.playservices |
Reporter | Joshua Quick |
Assignee | Joshua Quick |
Created | 2020-06-03T22:00:23.000+0000 |
Updated | 2020-11-23T21:44:22.000+0000 |
Description
*Summary:*
The "ti.playservices" module should update the Google Play Services base library it uses from version
17.1.0
to 17.5.0
.
https://developers.google.com/android/guides/releases#october_19_2020
*Note:*
Google appears to have fixed the bug with their makeGooglePlayServicesAvailable()
method where it would throw an exception when backing out of the activity that displayed the update dialog. This means we can use Google's standard update dialog instead of using our custom implementation here...
https://github.com/appcelerator-modules/ti.playservices/blob/master/android/Resources/ti.playservices/ti.playservices.js
PR (ti.playservices): https://github.com/appcelerator-modules/ti.playservices/pull/39
PR (master): https://github.com/appcelerator/titanium_mobile/pull/12246
merged to master for 9.3.0 target
Verified on: Mac OS: 10.15.4 SDK: 9.3.0.v20201123121926 Appc CLI: 8.1.1 JDK: 11.0.6 Node: 12.16.1 Studio: 6.0.0.202005141803 Device: Pixel 3 XL(v11.0) emulator