[TIMOB-2802] iOS: movieControlStyle Not Deprecated, mediaControlStyle doesn't work
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Trivial |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2012-01-05T16:27:36.000+0000 |
Affected Version/s | Release 1.6.0 |
Fix Version/s | Sprint 2011-47, Release 1.8.0.1 |
Components | iOS |
Labels | deprecated-1.6.0, deprecated-1.8.0, module_media, qe-testadded |
Reporter | Alan Leard |
Assignee | Stephen Tramer |
Created | 2011-04-15T03:29:55.000+0000 |
Updated | 2013-12-10T06:07:08.000+0000 |
Description
It seems that movieControlStyle is NOT depricated and that
mediaControlStyle does not work within
Titanium.Media.VideoPlayer.
Tested on iOS with 1.4.2, 1.5.1 and 1.6
This works:
var win = Titanium.UI.createWindow({
title: 'Test'
});
var activeMovie = Titanium.Media.createVideoPlayer
({
sourceType: Ti.Media.VIDEO_SOURCE_TYPE_FILE,
url: 'movie.mp4',
backgroundColor:'#000',
scalingMode: Titanium.Media.VIDEO_SCALING_ASPECT_FIT,
movieControlStyle: Titanium.Media.VIDEO_CONTROL_NONE
});
win.add(activeMovie);
win.open();
This doesn't:
var win = Titanium.UI.createWindow({
title: 'Test'
});
var activeMovie = Titanium.Media.createVideoPlayer
({
sourceType: Ti.Media.VIDEO_SOURCE_TYPE_FILE,
url: 'movie.mp4',
backgroundColor:'#000',
scalingMode: Titanium.Media.VIDEO_SCALING_ASPECT_FIT,
mediaControlStyle: Titanium.Media.VIDEO_CONTROL_NONE
});
win.add(activeMovie);
win.open();
One property is for 3.1.x, one property is for later iOS. Need to make sure that instead of cross-translating (which causes issues) we ignore and print deprecation warnings.
Jeff originally did the documentation for this (https://github.com/appcelerator/titanium_mobile/blame/1_7_X/apidoc/Titanium/Media/VideoPlayer.tdoc) and he calls the newer property
mediaControlStyle
. If I grep our iOS code I don't see anything starting with "mediaControl", but I do findmovieControlMode
andmovieControlStyle
. When Don implemented the play/pause/etc control for Android version of our VideoPlayer earlier this year, he followed the documentation (somediaControlStyle
). So we need to agree on which is right for the non-deprecated property:mediaControlStyle
ormovieControlStyle
.pull request pending.
Code and docs reviewed and tested. New code works, old code gives warnings but still work.
Closing bug. Verified deprecation of movieControlStyle on: OS: Mac OS X Lion Titanium Studio, build: 1.0.7.201112061404 SDK build: 1.8.0.1.v20111207112258 Device: iphone 4S Sprint (5.0.1)
Reopening to tag for deprecation in 1.8.0.
Reopening/closing to add/remove labels
Anvil testcase PR https://github.com/appcelerator/titanium_mobile/pull/5021