Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-28129] iOS: Peek and pop should not be guarded by the SDK

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2020-09-16T14:09:29.000+0000
Affected Version/sRelease 9.1.0
Fix Version/sRelease 9.2.0
ComponentsiOS
Labelsn/a
ReporterHans Knöchel
AssigneeVijay Singh
Created2020-09-12T16:20:41.000+0000
Updated2020-09-16T14:09:29.000+0000

Description

Currently, the peek and pop APIs are guarded by a \[Utils isForceTouchSupported\] check (which I added back in the days). This is wrong, because nowadays, Apple also allows peek and pop on long press, if force touch is not available. In addition, such checks should in general be performed by the developer (if wanted), not by the SDK. Therefore, removing the guard fixes the bug for us. PR: https://github.com/appcelerator/titanium_mobile/pull/12045

Comments

  1. Samir Mohammed 2020-09-15

    FR Passed, waiting on Jenkins build and ports.
  2. Samir Mohammed 2020-09-16

    *Closing ticket*. Fix verified in SDK version 9.2.0.v20200915123928, and 9.3.0.v20200915132757. *Test and other information can be found at:* https://github.com/appcelerator/titanium_mobile/pull/12045

JSON Source