[TIMOB-28390] Android: Change Ti.UI.SearchBar to use native SearchView
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2021-03-23T16:55:20.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 10.0.0 |
Components | Android |
Labels | SearchBar, android, breaking-change, material-design, searchview |
Reporter | Joshua Quick |
Assignee | Joshua Quick |
Created | 2021-03-12T23:54:34.000+0000 |
Updated | 2021-03-23T16:55:20.000+0000 |
Description
*Summary:*
Android's [Ti.UI.SearchBar](https://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.SearchBar) uses a custom implementation that does not look good using Titanium 10.0.0's material theme. We should change it to use the native [SearchView](https://developer.android.com/reference/androidx/appcompat/widget/SearchView) instead.
This is a breaking-change.
*Note:*
The [Ti.UI.Android.SearchView](https://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.Android.SearchView) already uses Google's native [SearchView](https://developer.android.com/reference/androidx/appcompat/widget/SearchView) class and looks fine using the material theme. We basically want to implement the same for
SearchBar
.
Attachments
File | Date | Size |
---|---|---|
ListViewSearchTest.js | 2021-03-13T00:16:28.000+0000 | 627 |
SearchBarEventTest.js | 2021-03-13T00:06:06.000+0000 | 1457 |
TableViewSearchTest.js | 2021-03-13T00:06:31.000+0000 | 644 |
PR (master): https://github.com/appcelerator/titanium_mobile/pull/12565
FR Passed. Waiting for Jenkins build.
merged to master and 10_0_X for 10.0.0 target.