[TIMOB-2902] iOS: legacy property allowImageEditing on Ti.Media.Camera doesn't do anything
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Trivial |
Status | Closed |
Resolution | Invalid |
Resolution Date | 2012-05-22T20:56:22.000+0000 |
Affected Version/s | Release 1.6.0 |
Fix Version/s | n/a |
Components | iOS |
Labels | n/a |
Reporter | Dawson Toth |
Assignee | Neeraj Gupta |
Created | 2011-04-15T03:32:31.000+0000 |
Updated | 2017-03-09T22:54:30.000+0000 |
Description
Problem
Ti.Media.Camera's property "allowImageEditing", replaced with "allowEditing", does not do anything anymore, and should be removed. Worse, if both allowImageEditing and allowEditing are specified, the value for allowEditing won't be applied!
Source
Taken from MediaModule.m, 214-221:
NSNumber * imageEditingObject = [args objectForKey:@"allowImageEditing"]; //backwards compatible
saveToRoll = [TiUtils boolValue:@"saveToPhotoGallery" properties:args def:NO];
if (imageEditingObject==nil)
{
imageEditingObject = [args objectForKey:@"allowEditing"];
editable = [TiUtils boolValue:imageEditingObject];
}
// introduced in 3.1
[picker setAllowsEditing:editable];
If "allowImageEditing" is not null, "editable" will always be
false, even if allowImageEditing is true and allowEditing is true.
Associated Helpdesk Ticket
http://developer.appcelerator.com/helpdesk/view/57161">http://developer.appcelerator.com/helpdesk/view/57161
Property doesn't exist anymore and the documentation is reflecting this change correctly. Ticket closed.
Closing ticket as invalid.