Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-2902] iOS: legacy property allowImageEditing on Ti.Media.Camera doesn't do anything

GitHub Issuen/a
TypeBug
PriorityTrivial
StatusClosed
ResolutionInvalid
Resolution Date2012-05-22T20:56:22.000+0000
Affected Version/sRelease 1.6.0
Fix Version/sn/a
ComponentsiOS
Labelsn/a
ReporterDawson Toth
AssigneeNeeraj Gupta
Created2011-04-15T03:32:31.000+0000
Updated2017-03-09T22:54:30.000+0000

Description

Problem

Ti.Media.Camera's property "allowImageEditing", replaced with "allowEditing", does not do anything anymore, and should be removed. Worse, if both allowImageEditing and allowEditing are specified, the value for allowEditing won't be applied!

Source

Taken from MediaModule.m, 214-221:


NSNumber * imageEditingObject = [args objectForKey:@"allowImageEditing"];  //backwards compatible
saveToRoll = [TiUtils boolValue:@"saveToPhotoGallery" properties:args def:NO];

if (imageEditingObject==nil)
{
    imageEditingObject = [args objectForKey:@"allowEditing"];
    editable = [TiUtils boolValue:imageEditingObject];
}

// introduced in 3.1
[picker setAllowsEditing:editable];

If "allowImageEditing" is not null, "editable" will always be false, even if allowImageEditing is true and allowEditing is true.

Associated Helpdesk Ticket

http://developer.appcelerator.com/helpdesk/view/57161">http://developer.appcelerator.com/helpdesk/view/57161

Comments

  1. Junaid Younus 2012-05-15

    Property doesn't exist anymore and the documentation is reflecting this change correctly. Ticket closed.
  2. Lee Morris 2017-03-09

    Closing ticket as invalid.

JSON Source