[TIMOB-3078] Android: Bugs in KS Base UI - Views - Image View - Animated test

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2011-04-17T02:00:51.000+0000
Affected Version/s	n/a
Fix Version/s	Release 1.6.0 M10
Components	Android
Labels	android, defect, lifecycle_refactor, regression, release-1.6.0, reported-1.6.0
Reporter	Bill Dawson
Assignee	Bill Dawson
Created	2011-04-15T03:36:13.000+0000
Updated	2011-04-17T02:00:51.000+0000

Description

Testing on 2.2 device with Titanium 1.6.0 49c5b13 (Mon Feb 7 21:26:27 2011 -0600).

Several symptoms:

The "Loading" indicator stays around forever (in Smoketest anyway, but not KS). (NOTE: see later comment. This was changed in KS but not Smoketest. So it's a non-issue.)
Sometimes no images appear. But this is very difficult to reproduce. It's happened to me a few times.
Sometimes when you go back it crashes the app. Log:

W/dalvikvm(10893): threadid=15: thread exiting with uncaught exception (group=0x400259f8)
E/TiUncaughtHandler(10893): (Thread-18) [1469,48790] Sending event: exception on thread: Thread-18 msg:java.lang.NullPointerException; Titanium 1.6.0,2011/02/08 17:42,9c5b13
E/TiUncaughtHandler(10893): java.lang.NullPointerException
E/TiUncaughtHandler(10893):     at ti.modules.titanium.ui.widget.TiUIImageView$Loader.isNotFinalFrame(TiUIImageView.java:227)
E/TiUncaughtHandler(10893):     at ti.modules.titanium.ui.widget.TiUIImageView$Loader.run(TiUIImageView.java:251)
E/TiUncaughtHandler(10893):     at java.lang.Thread.run(Thread.java:1102)
E/AndroidRuntime(10893): FATAL EXCEPTION: Thread-18
E/AndroidRuntime(10893): java.lang.NullPointerException
E/AndroidRuntime(10893):    at ti.modules.titanium.ui.widget.TiUIImageView$Loader.isNotFinalFrame(TiUIImageView.java:227)
E/AndroidRuntime(10893):    at ti.modules.titanium.ui.widget.TiUIImageView$Loader.run(TiUIImageView.java:251)
E/AndroidRuntime(10893):    at java.lang.Thread.run(Thread.java:1102)
W/ActivityManager(   96):   Force finishing activity com.appcelerator.SmokeTest/org.appcelerator.titanium.TiActivity

Attachments

File	Date	Size
no_images.png	2011-04-15T03:36:14.000+0000	20767

Comments

Bill Dawson 2011-04-15

Just so y'all don't think I'm crazy, here is the Titanium version info output during build of KitchenSink. I rebuild the SDK and KitchenSink, just to be sure:

Titanium SDK version: 1.6.0 (02/08/11 20:51 49c5b13)

That hash is precisely the HEAD of master at this moment. (The date/time shows my time now, because I just re-built the SDK.)

And the attached screen capture is of my device running the Image View - Animated test. In this case, there are no images displaying (the second condition noted above).
Bill Dawson 2011-04-15

The first issue I list above has already been addressed by a change in KS from Marshall at the time he committed many of the new message queue implementation changes. But the change isn't in Smoketest, so that's why I saw the behavior there. Marshall's relevant commit:

https://github.com/appcelerator/titanium_mobile/commit/76647275afd7304f48ea8535b55a3db9e1e1f666#diff-33"> https://github.com/appcelerator/titanium_mobile/commit/76647275afd7...
Bill Dawson 2011-04-15

I can't reliably reproduce the second issue (no images appear). It's happened twice -- one time I caught the screen capture for posterity, but neither time did I get a logcat. Bad boy. So we'll have to accept that one.
Bill Dawson 2011-04-15

(from [b27d06ff4e2818e3daf755c0a2c6eff84c1eac57]) [#3078 state:fixed-in-qa] check for imageSources being null before accessing https://github.com/appcelerator/titanium_mobile/commit/b27d06ff4e2818e3daf755c0a2c6eff84c1eac57"> https://github.com/appcelerator/titanium_mobile/commit/b27d06ff4e28...

Bill Dawson 2011-04-15

Adding to this ticket, because there is another place where "backing out" can cause an NPE:

   E/TiUncaughtHandler( 8676): (Thread-24) [398,283170] Sending event: exception on thread: Thread-24 msg:java.lang.NullPointerException; Titanium 1.6.0,2011/02/08 16:18,17c1ea
   E/TiUncaughtHandler( 8676): java.lang.NullPointerException
   E/TiUncaughtHandler( 8676):     at ti.modules.titanium.ui.widget.TiUIImageView$Loader.getStart(TiUIImageView.java:220)
   E/TiUncaughtHandler( 8676):     at ti.modules.titanium.ui.widget.TiUIImageView$Loader.run(TiUIImageView.java:251)
   E/TiUncaughtHandler( 8676):     at java.lang.Thread.run(Thread.java:1096)

Bill Dawson 2011-04-15

One additional way to test this and try to break it is to go in and out of the test quickly. Or go into it, click "Stop", click "Start" but then back out quickly before it really has a chance to start. Also go in, click "Stop", click "Reverse", click "Start", then go back fast before it can start.

Try to make it break, in other words.
Bill Dawson 2011-04-15

(from [67b6bde7b0c14e4b916180abd228a242432f8ff9]) Put more null checks in image view animator to avoid NPEs when user backs out of an animation. [#3078 state:fixed-in-qa] https://github.com/appcelerator/titanium_mobile/commit/67b6bde7b0c14e4b916180abd228a242432f8ff9"> https://github.com/appcelerator/titanium_mobile/commit/67b6bde7b0c1...
Bill Dawson 2011-04-15

(from [f666f8d2c6ccb03e523ad2216b66808ea054573e]) Put more null checks in image view animator to avoid NPEs when user backs out of an animation. [#3078 state:fixed-in-qa] https://github.com/appcelerator/titanium_mobile/commit/f666f8d2c6ccb03e523ad2216b66808ea054573e"> https://github.com/appcelerator/titanium_mobile/commit/f666f8d2c6cc...
Opie Cyrus 2011-04-15

Verified on Droid 2 (2.2) against KS built with 1_6_X

JSON Source