[TIMOB-3108] Android: change table view to respect search bar height property if it exists
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-17T02:00:56.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.6.0 M09 |
| Components | Android |
| Labels | android, defect, enterprise, release-1.6.0, reported-1.6.0, rplist |
| Reporter | Opie Cyrus |
| Assignee | Opie Cyrus |
| Created | 2011-04-15T03:37:11.000+0000 |
| Updated | 2011-04-17T02:00:56.000+0000 |
Description
If a search bar is added to a table view, use the height specify in he search bar properties. Otherwise, default to 52dp.
Created in response to http://developer.appcelerator.com/helpdesk/view/72301#c341291">http://developer.appcelerator.com/helpdesk/view/72301#c341291
Attachments
| File | Date | Size |
|---|---|---|
| app.js | 2011-04-15T03:37:11.000+0000 | 1283 |
(from [58f75b2f32c24c1226028cd90a79321e4613b87e]) [#3108 state:fixed-in-qa] update table view to respect height property for search bar
Updated TiUITableView to respect the height property on a search bar. Defaults to dp instead of px if the height is not specified.
https://github.com/appcelerator/titanium_mobile/commit/58f75b2f32c24c1226028cd90a79321e4613b87e"> https://github.com/appcelerator/titanium_mobile/commit/58f75b2f32c2...
Fix can be verified with the attached app.js
3 tabs are displayed each with its own search bar. 1st search bar has height set to custom dp value. 2nd has px value set. 3rd has no height specified and thus uses default height.
(from [9db0685d0ad6a57f5814ad22585be0bd901a02fe]) [#3108 state:fixed-in-qa] update table view to respect height property for search bar
Updated TiUITableView to respect the height property on a search bar. Defaults to dp instead of px if the height is not specified.
(cherry picked from commit 58f75b2f32c24c1226028cd90a79321e4613b87e) https://github.com/appcelerator/titanium_mobile/commit/9db0685d0ad6a57f5814ad22585be0bd901a02fe"> https://github.com/appcelerator/titanium_mobile/commit/9db0685d0ad6...
thanks for test content, closing against G1 (1.6) galaxy tab (2.2.2) Nexus s (2.3.2) and sim 2.1 using [INFO] Titanium SDK version: 1.6.0 (02/14/11 10:55 bd9d124).