[TIMOB-3116] Titanium Developer: Clicking save at project edit screen wipes out our default appicon.png and replaces with default_app_logo.png
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Low |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2011-04-17T02:00:58.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 1.6.0 M09 |
Components | iOS |
Labels | defect, developer, release-1.6.0, titanium |
Reporter | Bill Dawson |
Assignee | Bill Dawson |
Created | 2011-04-15T03:37:18.000+0000 |
Updated | 2011-04-17T02:00:58.000+0000 |
Description
Recreate the fail case:
-
Create a new mobile project in Developer.
-
When you are finished creating it, you'll notice that the "Application Icon" is set to our standard, which is appicon.png. You'll see appicon.png in the filesystem under Resources/iphone and Resources/android.
-
When sitting at the project edit screen for the just-created-and-saved project, click "Save Changes" even though you have not changed anything.
-
Click on the "Test & Package" tab. But don't launch the app.
-
Click back on the "Edit" tab.
-
Look at the "Application Icon" field. It will now say "default_app_logo.png". If you look in the filesytem, you'll see Resources/default_app_logo.png (it wasn't there before you clicked Save Changes).
What's happening? The code in Developer is checking your entry for Application Icon (which was set to appicon.png) and checking to see if that file exists in the Resources folder. Well it doesn't exist in the Resources folder, it exists in Resources/iphone and Resources/android. Not seeing it in Resources, Developer then copies out the file default_app_logo.png file to Resources and resets the Application Icon field to default_app_logo.png.
appicon.png and default_app_logo.png are basically the same image, which is why we really haven't noticed this weirdness before. But the image in default_app_logo.png is 512x512, whereas the image in Resources/android/appicon.png is 128x128 and the image in Resources/iphone/appicon.png is 57x57.
The large size of default_app_logo.png has caused a problem for the first time in Android: see ticket #3104.
Attachments
File | Date | Size |
---|---|---|
3116.diff | 2011-04-15T03:37:18.000+0000 | 2127 |
I have a (very simple) fix already but haven't pushed it, because I know we treat changes to Developer with special care. It's in the attached diff.
I propose we add this to 1.3.0, because anybody who tests out our Urban Airship module for Android is going to run into a very ugly bug (#3104) that gives no indication whatsoever what the problem is (it took me a long time to figure out what was happening.)
Fixed in TiDev, thanks to Bill's patch. See:
https://github.com/appcelerator/titanium_developer/commit/11189bf3c97a7d01b91391d1a2dfc9035e38beaa"> https://github.com/appcelerator/titanium_developer/commit/11189bf3c...
waiting for 1.3.0 testing to close this
confirmed mac fix (using TiDev-1.3.0-021511) , checking windows next
ubuntu 10 confirmed
and closing for win 7! woot.