[TIMOB-3331] Android: passwordMask does not disable autocomplete and dictionary

Disable autocorrect and autocapitalization does also not work, see:
http://developer.appcelerator.com/question/116625/android-kitchensink---disable-autocorrect-not-correct-working-when-password-mask-is-enabled"> http://developer.appcelerator.com/question/116625/android-kitchensi...

I've fixed this in a fork, and have requested a pull request on github: https://github.com/appcelerator/titanium_mobile/pull/81">https://github.com/appcelerator/titanium_mobile/pull/81
Hopefully they'll pull the patch, and this should be fixed soon.

If you're feeling adventurous, you can clone my fork and build it. :)

Hi Guys,

please accept that pull request if it solves the problem. It's really annoying when users try to login and their password is saved in the dictionary. Many users are complaining about that.

Thanks and kind regards,
Dennis

I'm also getting complaints about this, users can't log in because their passwords are auto-completed with capital letters (Yeah, I know they can override the autocomplete, but they don't know that...)

I'm going to look at this, but have you guys tried setting autocorrect : false in the creation args of the text field? Just trying to narrow it down.

I have tried using autocorrect:false with the same result. Here is the textField I used for testing.

   var passwordField = Ti.UI.createTextField({
           returnKeyType   : Titanium.UI.RETURNKEY_DONE,
           enableReturnKey : true,
           hintText        : 'Password',
           value           : '',
           color           : '#666',
           top             : 50,
           width           : '90%',
           passwordMask    : true,
           autocorrect     : false
   });
   

Slipping into 14, can't find a fix that doesn't break other features yet.

If it breaks, why is this not commented on the pull request? I would be more than happy to fix it.
https://github.com/appcelerator/titanium_mobile/pull/81">https://github.com/appcelerator/titanium_mobile/pull/81

It should trigger if password masking is enabled, and I don't see any obvious reasons not to switch to InputType.TYPE_TEXT_VARIATION_PASSWORD.

I'm testing across emulators and devices other than 2.3. If I could tell you what to fix, I'd already have fixed it. It looks likes like the problem is 2.3 dependent on device. No worries just trying to work through all the combinations where the value gets set and unset.

Interesting ... I couldn't reproduce the bug in the emulator, but showed up on my Samsung Galaxy S. Didn't try other Android versions in the emulator than the one I had set up though.
Is the bug reproducible in the Android emulator at all?

We tested on 2.2.2 and 2.3.1 with the patch and it seems to be ok due to the order of when the password mask is applied. Thanks @vetler for the patch. Sorry it took this long, but other variations I was testing with flags were having some issues. I'm not positive there won't be a side-effect if someone tries to switch a password field to another field, but that's not the normal use case.

https://github.com/appcelerator/titanium_mobile/commit/bbe956c79e537faa51c191ef1af2a9892933a5a7"> https://github.com/appcelerator/titanium_mobile/commit/bbe956c79e537faa51c191ef1af2a9892933a5a7

Great, happy to help! :)