[TIMOB-362] Layout lost when filtering table view
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2011-04-17T01:52:49.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 1.3.0 |
Components | iOS |
Labels | bug, feature |
Reporter | Kevin Whinnery |
Assignee | Reggie Seagraves |
Created | 2011-04-15T02:27:53.000+0000 |
Updated | 2011-04-17T01:52:49.000+0000 |
Description
When using the search feature for table views, any custom filtering/formatting is lost. A few community members have commented on this, including in this issue:
http://support.appcelerator.net/discussions/support/1156-layout-template-lost-from-searchbar-results"> http://support.appcelerator.net/discussions/support/1156-layout-tem...
Logging an issue here to decide whether or not we want to support keeping table view row layouts in the filtering view.
It's two months down the road on this one.
Tableview search still doesn't support the design of the Tableview. The impact being we can create the most polished tableview designs but these get replace by bland black text on white background as soon as the the user searches (I don't see how this is different to edit/delete modes for Tableviews, where the styling is maintained).
December 15th 2009:
http://support.appcelerator.net/discussions/titanium-mobile-discussion/1123-customize-filter-results"> http://support.appcelerator.net/discussions/titanium-mobile-discuss...
January 24th 2010:
http://support.appcelerator.net/discussions/support/1287-searching-a-tableview-with-html-or-templates"> http://support.appcelerator.net/discussions/support/1287-searching-...
I was about to mention how Apple's own apps have precedent to have the search be intentionally boring, but it turns out I'm wrong on that.
Possible solutions:
1: In 3.0, a built-in search ability was given to table views. Due to 0.8 and before working with 2.x, this isn't currently used, but could be. I need to look into the abilities.
Pro: Future proofing, as features Apple adds to this are obtained for nearly free. Ensures look and feel consistency.
Cons: Unknown support of titanium properties that are applied to the searchView we have, or to the look and feel of the tableview that represents the search.
2: Showing results are in the exact same format as the standard table UI.
Pro: Might be the simplest to implement.
Cons: Might be the ugliest effect; That is, table view layouts that work well when unfiltered might look awkward when filtered.
3: A new property on tableRowCell called 'searchView', which represents the layout of a cell when in the search format.
Pro: When not used, falls back into (2), but lets the end dev avoid 2's cons.
Cons: More difficult to implement, might be more expensive computationally.
Suggesting going with 1. Namely, because of https://appcelerator.lighthouseapp.com/projects/32238/tickets/643-table-view-filter-search-bar-ui-issues"> https://appcelerator.lighthouseapp.com/projects/32238/tickets/643-t... , it may be time to switch from our custom-rolled search implementation to the 3.0-provided one, which may give us this and some other things for free.
Taking over at Blain's request. Will probably involve slicing out a bunch of the existing search code in favor of the new(ish?) 3.0 stuff.
Possibly fixed by Blain (or whoever) in the update to 3.0-style search. There is one interesting side-effect: If your table has rows with background images that contain transparency, they will NOT show the background underneath the table, due to the search view table not being transparent.
So row settings are preserved, but possibly not tables (due to a new table being created for the search). Looking into this.
(from [75732610944572f4d1cdc92d9b3a04762a3cb558]) Closes #362: Table properties now preserved in search table. http://github.com/appcelerator/titanium_mobile/commit/75732610944572f4d1cdc92d9b3a04762a3cb558"> http://github.com/appcelerator/titanium_mobile/commit/7573261094457...
Guys what's the final status on this?
I can see the tkt has been closed but so far KitchenSink doesn't have any good example of this working and if I try on my app can't get it done, as soon I start the search any tableviewrow style (image, label etc.) disappear... displaying a simple tableview with a single row/text.
Thanks.
See #1037.
rollback wrong update