[TIMOB-4628] Android: Titanium.buildHash is off by one character
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Low |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2011-07-29T11:47:31.000+0000 |
Affected Version/s | Release 1.8.0 |
Fix Version/s | Sprint 2011-27, Release 1.7.2, Release 1.8.0 |
Components | Android |
Labels | n/a |
Reporter | Bill Dawson |
Assignee | Natalie Huynh |
Created | 2011-07-08T14:40:52.000+0000 |
Updated | 2011-08-25T12:55:26.000+0000 |
Description
To reproduce the failcase (and test the fix):
* Run
git log
in your source folder and jot down the top build hash.
* Build and release the SDK if you haven't already.
* Build and run the app (app.js) below.
In the failcase, you'll see only a 6-character build hash which is missing the first character of the real hash. In the fixed case, you'll see the full 7-character build hash.
Here's the app.js:
Titanium.UI.setBackgroundColor('#000');
var win = Titanium.UI.createWindow({
title:'Test',
backgroundColor:'#000',
exitOnClose: true
});
win.add(Ti.UI.createTextArea({
value: "Build Hash: " + Ti.buildHash +
"\nBuild Date: " + Ti.buildDate +
"\nTitanium Version: " + Ti.version,
top: "25%",
left: "10dp",
right: "10dp",
height: "200dp"
}));
win.open();
Removed "Release 1.8.0" fixVersion. Issue has not been merged. Set Task Type to "Release"
also merged into 1_7_X
with newer builds of Git the substring is off by 1 again. we need to switch to git rev-parse
merged and confirmation conversation.
Tested with 1.8.0.v20110819142548 iPhone 4.3.4 iPad2 4.3.2 Motorola Xoom 3.2 Nexus One 2.2.2