[TIMOB-4758] Tooling: Fix scons error on Windows
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-08-05T20:52:35.000+0000 |
| Affected Version/s | Release 1.7.1 |
| Fix Version/s | Sprint 2011-31, Release 1.8.0 |
| Components | Tooling |
| Labels | n/a |
| Reporter | Opie Cyrus |
| Assignee | Opie Cyrus |
| Created | 2011-07-25T09:07:44.000+0000 |
| Updated | 2017-03-03T22:48:03.000+0000 |
Description
scons build still fails on Windows 7 64bit. SConstruct and Package.py both need to be changed to conditionally append ".cmd" to git when on Windows in order for build to run correctly.
For example in package.py:
p = subprocess.Popen(["git.cmd","show","--abbrev-commit"],stderr=subprocess.PIPE, stdout=subprocess.PIPE)
For example in SConstruct:
p = subprocess.Popen(["git.cmd","log","--oneline","--max-count=1"],stderr=subprocess.PIPE, stdout=subprocess.PIPE)
Closing ticket.