[TIMOB-5163] iOS: Migrate Ti.Facebook.LoginButton constants to Ti.Facebook and rename
| GitHub Issue | n/a |
|---|
| Type | Bug |
|---|
| Priority | Low |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2012-01-05T10:41:00.000+0000 |
|---|
| Affected Version/s | Release 1.7.2 |
|---|
| Fix Version/s | Sprint 2011-46, Release 1.8.0.1 |
|---|
| Components | iOS |
|---|
| Labels | deprecated-1.8.0, parity, qe-testadded |
|---|
| Reporter | Stephen Tramer |
|---|
| Assignee | Sabil Rahim |
|---|
| Created | 2011-08-29T15:08:12.000+0000 |
|---|
| Updated | 2012-01-05T10:41:00.000+0000 |
|---|
Description
The constants on Ti.Facebook.LoginButton (STYLE_WIDE and STYLE_NORMAL) need to be:
* Moved to Ti.Facebook
* Renamed to BUTTON_STYLE_WIDE, BUTTON_STYLE_NORMAL
Please keep the original names in for backwards compatibility in 1.9 and deprecate.
----------------------------------------------------------------------------------------------
NOTE FOR QE: While testing, its worth noting that now in Mashup/Facebook/
*login/logout & photos would show a wide faceebook button.
*Query,Properties, Publish Stream show a normal facebook button.
----------------------------------------------------------------------------------------------
Attachments
| File | Date | Size |
|---|
| app.js | 2011-11-18T13:36:43.000+0000 | 1151 |
STYLE_WIDE AND STYLE_NORMAL where undocumented and unused/unusable ..Therefore instead of migrating it, it has been removed.
Should have been clearer when initially creating this issue; iOS does not support these STYLE constants; we actually needed to create them. We should replace the internal usage of "wide" and whatever other string descriptor is used to load style with these constants. Please get in touch with Android as well, to see if they have these constants floating around too, and what their values are.
Testing file Attached : "app.js"
pull pending # 734
Closing bug. Verified fix on: OS: Mac OS X Lion Titanium Studio, build: 1.0.7.201112080131 SDK build: 1.8.0.1.v20111207180431 Devices: iphone 4S Sprint (5.0.1)
Reopening to add deprecation label.
Reopening/closing to add/remove labels