[TIMOB-5812] iOS: Support UIMenuController
GitHub Issue | n/a |
---|---|
Type | New Feature |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-02-16T15:30:51.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 5.2.0 |
Components | iOS |
Labels | ios, menupopup, notable, qe-5.2.0 |
Reporter | Sindre Sorhus |
Assignee | Hans Knöchel |
Created | 2011-10-19T10:52:21.000+0000 |
Updated | 2016-02-19T19:08:31.000+0000 |
Description
!http://i.stack.imgur.com/yQKL4.png!
Would be a useful feature to have. Already need it for so much. This is something that should be built-in.
Here is the documentation for it: http://developer.apple.com/library/IOS/#documentation/iPhone/Reference/UIMenuController_Class/UIMenuController.html
This would be an awesome feature. It's one of the latest feature that is not yet in Ti...
Still nothing?
Try this: https://github.com/alexshive/TiPopup
PR pending: https://github.com/appcelerator/titanium_mobile/pull/7408 Demo:
Approved! PR merged.
Tested new feature and verified as working correctly. Investigated methods & properties are functioning correctly. Compatible with iOS8 & iOS9. iPhone 6s Plus Device (9.2) & iPhone 6 Plus Device (8.4) Mac OSX El Capitan 10.11 (15A284) Ti SDK: 5.2.0.v20160114021251 Appc NPM: 4.2.2 App CLI: 5.2.0-220 Xcode 7.2 Node v4.2.3 *Closing ticket.*
[~hansknoechel] nice addition. Just wondering; why did you call it MenuPopup? Why not just Menu since the iOS API doesn't mention popup? It [does say](https://developer.apple.com/library/prerelease/ios/documentation/iPhone/Reference/UIMenuController_Class/index.html) "This menu is referred to as the editing menu" so it could be EditingMenu perhaps.
[~hansknoechel] The
hide()
method doesn't work. Please see the [sample](https://github.com/appcelerator-developer-relations/appc-sample-ti520/blob/master/app/controllers/menupopup.js#L63) where I callhide()
after a time out. It does not hide. Instead, it freezes and tapping anywhere else no longer hides it as well.Updated to run methods on main thread (same thing like with the LivePhoto): PR (master): https://github.com/appcelerator/titanium_mobile/pull/7735 PR (5_2_X) https://github.com/appcelerator/titanium_mobile/pull/7736
CR and FT passed. PRs merged.
Verified as fixed, I was able to reproduce the issue as stated by [~fokkezb] using sdk version
5.2.0.v20160208101502
. Using the latest build, The issue is no longer reproducible, thehide
method does no longer freezes the app, and correctly hides the menu after a timeout period. Tested on: iPhone 6S device (9.2) & iPhone 6Plus (8.2) Mac OSX El Capitan 10.11.3 (15D21) Ti SDK: 5.2.0.v20160216202526 Appc Studio: 4.5.0.201602170821 Appc NPM: 4.2.3-2 App CLI: 5.2.0-269 Xcode 7.2 Node v4.2.6 production *Closing ticket.*