[TIMOB-6234] Android: Change Ti.Facebook.LoginButton style properties string "wide" and "normal" to constants
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | Trivial |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2012-04-05T10:36:56.000+0000 |
| Affected Version/s | Release 1.8.0.1 |
| Fix Version/s | Release 2.1.0, Sprint 2012-07 |
| Components | Android |
| Labels | api |
| Reporter | Sabil Rahim |
| Assignee | Arthur Evans |
| Created | 2011-11-18T11:38:11.000+0000 |
| Updated | 2012-06-05T17:47:52.000+0000 |
Description
We actually created new style constants as part of the parity bug timob-5163. It replaces the internal usage of "wide" & "normal" and replaces it with constants Ti.Facebook.BUTTON_STYLE_WIDE & Ti.Facebook.BUTTON_STYLE_NORMAL.
Please keep the original names in backward compatibility in 1.9 and deprecate it.
Parity bug for the same issue.
Since this can be automated, we should also be adding a drillbit test for these properties
We don't seem to have any drillbit tests for Facebook. Did you just want to test for the existence of the constants, or...?
Added drillbit test. Also note that the updated KitchenSink can be used as a test for this. With these changes, running Mashups > Facebook tests in KS should: 1) Not throw an exception. 2) Show the appropriately sized button.
Tested with version=2.1.0 module_apiversion=2 timestamp=06/05/12 17:26 githash=2b67019 on Droid 3 2.3.4