[TIMOB-7529] Android: Titanium.UI.TabGroup: addTab with Label argument crashes app
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Invalid |
| Resolution Date | 2012-02-07T16:45:42.000+0000 |
| Affected Version/s | Release 1.8.0.1, Release 1.8.1 |
| Fix Version/s | n/a |
| Components | Android |
| Labels | look1 |
| Reporter | Dustin Hyde |
| Assignee | Hieu Pham |
| Created | 2012-02-02T17:09:11.000+0000 |
| Updated | 2017-03-22T21:00:53.000+0000 |
Description
Attachments
| File | Date | Size |
|---|---|---|
| android log.txt | 2012-02-02T17:09:11.000+0000 | 7584 |
IMHO, "addTab" method should not accept Label as parameter, as it's name says it should accept Tab, so crash should be expected behavior.
This issue latest notification was not sent due to JIRA mail setting. Fixed now. Please check the issue for latests changes.
We may want to look into why the Java exception wasn't caught and converted to a JS exception (and error dialog). The application shouldn't be crashing from Java exceptions thrown during a Kroll method call. Also adding proxy type validation (instanceof) in the Kroll layer may be worth looking into. This way the Java method is always called with the correct type and invalid types of objects are caught early while still in the Kroll layer.
marking as wont fix since we are not going to put a fix in for this specific instance
This is an application bug and not a platform issue.
Closing ticket as invalid with reference to the above comments.