[TIMOB-7938] Android: Sample module does not build due to change in TiCompositeLayout constructor

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2012-03-09T11:52:30.000+0000
Affected Version/s	Release 2.0.0
Fix Version/s	Sprint 2012-05, Release 2.0.0
Components	Android
Labels	module_module, qe-testadded
Reporter	Allen Yeung
Assignee	Allen Yeung
Created	2012-03-08T14:44:50.000+0000
Updated	2012-07-09T10:29:40.000+0000

Description

The constructor arguments were changed to TiCompositeLayout(Context context, LayoutArrangement arrangement, TiViewProxy proxy) instead of TiCompositeLayout(Context context, LayoutArrangement arrangement). As a result, the default module project doesn't build with this change.

Comments

Allen Yeung 2012-03-08

To test: 1. build a new module 2. verify that the properties in build.properties are correct 3. run 'ant' on the root of the module The module should build without any errors.
Allen Yeung 2012-03-08

PR ready: https://github.com/appcelerator/titanium_mobile/pull/1607

Eduardo Gomez 2012-03-08

Build a new module w/ 2.0.0.v20120216180135 without any issues. Not sure what do I need to do to replicate the issue though...

   eGomez-MacBook-Pro:android_composite_layout egomez$ antBuildfile: /Users/egomez/temp/android_composite_layout/build.xml
   
   init:
   
   process.annotations:
   
   generate.rhino.bindings:
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/java/com/android/ExampleProxyPrototype.java
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/java/com/android/AndroidCompositeLayoutModulePrototype.java
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/java/android_composite_layoutGeneratedBindings.java
   
   generate.rhino.idswitch:
        [echo] Generating IDs for /Users/egomez/temp/android_composite_layout/build/generated/java/android_composite_layoutGeneratedBindings.java
        [echo] Generating IDs for /Users/egomez/temp/android_composite_layout/build/generated/java/com/android/AndroidCompositeLayoutBootstrap.java
        [echo] Generating IDs for /Users/egomez/temp/android_composite_layout/build/generated/java/com/android/AndroidCompositeLayoutModulePrototype.java
        [echo] Generating IDs for /Users/egomez/temp/android_composite_layout/build/generated/java/com/android/ExampleProxyPrototype.java
   
   generate.v8.bindings:
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/jni/com.android.ExampleProxy.h
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/jni/com.android.ExampleProxy.cpp
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/jni/com.android.AndroidCompositeLayoutModule.h
        [java] Generating /Users/egomez/temp/android_composite_layout/build/generated/jni/com.android.AndroidCompositeLayoutModule.cpp
   
   generate.bindings:
   
   pre.compile:
   
   ndk.build:
        [copy] Copying 1 file to /Users/egomez/temp/android_composite_layout/build/generated
        [copy] Copying 1 file to /Users/egomez/temp/android_composite_layout/build/generated/jni
        [exec] jni/Android.mk:24: warning: overriding commands for target /Users/egomez/temp/android_composite_layout/build/generated/KrollGeneratedBindings.cpp'
        [exec] jni/Android.mk:24: warning: ignoring old commands for target /Users/egomez/temp/android_composite_layout/build/generated/KrollGeneratedBindings.cpp'
        [exec] jni/Android.mk:27: warning: overriding commands for target /Users/egomez/temp/android_composite_layout/build/generated/BootstrapJS.cpp'
        [exec] jni/Android.mk:27: warning: ignoring old commands for target /Users/egomez/temp/android_composite_layout/build/generated/BootstrapJS.cpp'
        [exec] Compile++ thumb  : com.android <= com.android.AndroidCompositeLayoutModule.cpp
        [exec] Compile++ thumb  : com.android <= com.android.ExampleProxy.cpp
        [exec] gperf -L C++ -E -t "/Users/egomez/temp/android_composite_layout/build/generated/KrollGeneratedBindings.gperf" > "/Users/egomez/temp/android_composite_layout/build/generated/KrollGeneratedBindings.cpp"
        [exec] "python" "/Library/Application Support/Titanium/mobilesdk/osx/2.0.0.v20120216180135/module/android/js2c.py" "/Users/egomez/temp/android_composite_layout/build/generated/BootstrapJS.cpp" "/Users/egomez/temp/android_composite_layout/build/generated/bootstrap.js"
        [exec] Compile++ thumb  : com.android <= AndroidCompositeLayoutBootstrap.cpp
        [exec] In file included from jni/../AndroidCompositeLayoutBootstrap.cpp:17:
        [exec] /Users/egomez/temp/android_composite_layout/build/generated/KrollGeneratedBindings.gperf:14: warning: declaration 'struct titanium::bindings::BindEntry' does not declare anything
        [exec] Prebuilt       : libstlport_shared.so <= <NDK>/sources/cxx-stl/stlport/libs/armeabi/
        [exec] SharedLibrary  : libcom.android.so
        [exec] Install        : libcom.android.so => libs/armeabi/libcom.android.so
        [exec] Install        : libstlport_shared.so => libs/armeabi/libstlport_shared.so
        [exec] Compile++ thumb  : com.android <= com.android.AndroidCompositeLayoutModule.cpp
        [exec] Compile++ thumb  : com.android <= com.android.ExampleProxy.cpp
        [exec] Compile++ thumb  : com.android <= AndroidCompositeLayoutBootstrap.cpp
        [exec] In file included from jni/../AndroidCompositeLayoutBootstrap.cpp:17:
        [exec] /Users/egomez/temp/android_composite_layout/build/generated/KrollGeneratedBindings.gperf:14: warning: declaration 'struct titanium::bindings::BindEntry' does not declare anything
        [exec] Prebuilt       : libstlport_shared.so <= <NDK>/sources/cxx-stl/stlport/libs/armeabi-v7a/
        [exec] SharedLibrary  : libcom.android.so
        [exec] Install        : libcom.android.so => libs/armeabi-v7a/libcom.android.so
        [exec] Install        : libstlport_shared.so => libs/armeabi-v7a/libstlport_shared.so
        [copy] Copying 2 files to /Users/egomez/temp/android_composite_layout/libs
   
   compile:
       [javac] Compiling 4 source files to /Users/egomez/temp/android_composite_layout/build/classes
        [copy] Copying 1 file to /Users/egomez/temp/android_composite_layout/build/classes
   
   post.compile:
   
   pre.dist:
   
   dist:
         [jar] Building jar: /Users/egomez/temp/android_composite_layout/dist/android_composite_layout.jar
   
   post.jar:
   
   pre.docgen:
   
   docgen:
        [exec] Creating dir: /Users/egomez/temp/android_composite_layout/build/docs
        [exec] Generating /Users/egomez/temp/android_composite_layout/build/docs/index.html
   
   post.docgen:
         [zip] Building zip: /Users/egomez/temp/android_composite_layout/dist/com.android-android-0.1.zip
   
   libs.check:
   
   zip.libs:
         [zip] Updating zip: /Users/egomez/temp/android_composite_layout/dist/com.android-android-0.1.zip
   
   post.dist:
   
   BUILD SUCCESSFUL
   Total time: 14 seconds

Build.properties

{noformat} titanium.platform=/Library/Application Support/Titanium/mobilesdk/osx/2.0.0.v20120216180135/android android.platform=/Users/egomez/Documents/android-sdk-mac_x86/platforms/android-8 google.apis=/Users/egomez/Documents/android-sdk-mac_x86/add-ons/addon-google_apis-google_inc_-8 {noformat}

Michael Pettiford 2012-03-19

Closing issue Tested with Ti Studio build 2.0.0.201203182248 Ti Mob SDK 2.0.0.v20120319003254 hash r60b6da4c OSX Lion 10.7.3 Verified that I was able to build a module succesfully

JSON Source