[TIMOB-1037] Table search needs to preserve row layout
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-17T01:55:01.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.4.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Stephen Tramer |
| Assignee | Stephen Tramer |
| Created | 2011-04-15T02:42:05.000+0000 |
| Updated | 2011-04-17T01:55:01.000+0000 |
Description
See Base UI -> Table View -> Layout 2 and conduct a search. Rows returned by the search are reconstituted from the search string, and are not the original row; HIG demands that we present the search results in a manner consistent with the original table.
I guess this was a different bug and I accidentally closed it for the wrong reasons. Oops!
(from [9d2b8751f3fb5217af5fcacb091da1be9b94edd7]) Closes #1037: Search now loads appropriate rows from the table data. See caveats in bug. http://github.com/appcelerator/titanium_mobile/commit/9d2b8751f3fb5217af5fcacb091da1be9b94edd7"> http://github.com/appcelerator/titanium_mobile/commit/9d2b8751f3fb5...
Okay, there is one caveat: If you use table view level event listeners to process row events, they WILL NOT work with search - this is because search is an entirely different table, and can only process events at the row level (at highest).
We may wish to add a separate event type (searchClick?) to tables as well so that search handling can be different from regular clicks (for example, showing the user the row in the table rather than performing that row's action).
Would be great having a KitchenSink demo updated :)
in the meantime, shall I simply replace those two files in my Titanium Mobile? Or do I need a full compile?
Cheers.