Titanium

[TIMOB-1260] InsertRowAfter & insertRowbefore do not respect the header property of createTableRow

GitHub Issuen/a
TypeBug
PriorityTrivial
StatusClosed
ResolutionFixed
Resolution Date2011-04-17T01:55:40.000+0000
Affected Version/sn/a
Fix Version/sRelease 1.5.0
ComponentsiOS
Labelscreation, defect, ios, iphone, row, tableview
Reporterctredway
AssigneeBlain Hamon
Created2011-04-15T02:47:59.000+0000
Updated2011-04-17T01:55:40.000+0000

Description

Using the attached file (code came from the kitchen sink), if a new table row is created via insertRowAfter/Before, setting the header property is ignored. Using appendRow does honor that property though. I have run this using OS 4(iphone project) and our latest from HEAD today.

Attachments

FileDateSize
rowinsert.js2011-04-15T02:47:59.000+00001703

Comments

  1. Jeff Haynie 2011-04-15

    (from [fca3d660d7cfcafd0cb72f298edbe8957be30d59]) [#1260 state:fixed-in-qa]: Fixes to allow row headers for insert. SEE TICKET FOR CAVEATS. http://github.com/appcelerator/titanium_mobile/commit/fca3d660d7cfcafd0cb72f298edbe8957be30d59"> http://github.com/appcelerator/titanium_mobile/commit/fca3d660d7cfc...

  2. Stephen Tramer 2011-04-15

    Note that the comment specifically mentioned caveats.

    • It is UNAVOIDABLE to have the 'row removal' animation to maintain consistency. Rows on iPhone do not have headers - only sections. We emulate row headers by creating a new section to contain the row.
    • It is UP TO THE USER to determine whether or not to scroll to the newly inserted row with header. We do not enforce any kind of scrolling automagically. Note that the updated KS example has for 'insert above header 2' has an example of scrolling to the inserted row.

    KS was also updated to include a number of test cases (table_view_row_insert.js).

  3. Thomas Huelbert 2011-04-15

    confirmed against 1.4.1.4dc5ff, has testcase

JSON Source