[TIMOB-1316] ipad popover buttons bug

GitHub Issue	n/a
Type	Bug
Priority	Trivial
Status	Closed
Resolution	Fixed
Resolution Date	2011-04-17T01:55:50.000+0000
Affected Version/s	n/a
Fix Version/s	Release 1.5.0
Components	iOS
Labels	ipad, popover
Reporter	Tamas Daniel
Assignee	Reggie Seagraves
Created	2011-04-15T02:49:12.000+0000
Updated	2011-04-17T01:55:50.000+0000

Description

for an ipad popover the left button cannot be set because it points to the right button

TiUIiPadPopoverProxy.m line 112

-(void)setRightNavButton:(id)item withObject:(id)properties {

ENSURE_SINGLE_ARG_OR_NIL(item,TiViewProxy);
[self replaceValue:item forKey:@"rightNavButton" notification:NO];
[self refreshTitleBarWithObject:properties];

}

-(void)setLeftNavButton:(id)item withObject:(id)properties {

ENSURE_SINGLE_ARG_OR_NIL(item,TiViewProxy);
[self replaceValue:item forKey:@"rightNavButton" notification:NO];
[self refreshTitleBarWithObject:properties];

}

Comments

Tamas Daniel 2011-04-15

the solution is really simple

change this code

-(void)setLeftNavButton:(id)item withObject:(id)properties {

   ENSURE_SINGLE_ARG_OR_NIL(item,TiViewProxy);
   [self replaceValue:item forKey:@"rightNavButton" notification:NO];
   [self refreshTitleBarWithObject:properties];

}

-(void)setLeftNavButton:(id)item withObject:(id)properties {

   ENSURE_SINGLE_ARG_OR_NIL(item,TiViewProxy);
   [self replaceValue:item forKey:@"leftNavButton" notification:NO];
   [self refreshTitleBarWithObject:properties];

}

Don Thorp 2011-04-15

Tamas says this is fixed. Please verify.
Thomas Huelbert 2011-04-15

confirmed fixed in 1.4.1

valid, needs testcase
Jeff Haynie 2011-04-15

(from [bbfceb47c73327e47089375e8f92ad9cac75361f]) [#1316 state:resolved] added leftNav to popOver http://github.com/appcelerator/titanium_mobile/commit/bbfceb47c73327e47089375e8f92ad9cac75361f"> http://github.com/appcelerator/titanium_mobile/commit/bbfceb47c7332...

JSON Source