[TIMOB-1358] Android - add support for .buildHash and .buildDate
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | Low |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-17T01:55:58.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.5.0 M04 |
| Components | Android |
| Labels | android, feature |
| Reporter | Thomas Huelbert |
| Assignee | Don Thorp |
| Created | 2011-04-15T02:50:21.000+0000 |
| Updated | 2011-04-17T01:55:58.000+0000 |
Description
Titanium.buildHash and Titanium.buildDate return null on android, return values on iOS.
[DST] Implementation Note: Log the information at the top of each builder.py run with our other diagnostic information at the INFO level. This will make it easier to diagnose then going into the app.
Comments
- Don Thorp 2011-04-15
site_scons/package.py builds version.txt and drops it into the mobilesdk/OS/VERSION dir. Then it looks like support/iphone/builder.py processes the file to make it available to the application.
- Thomas Huelbert 2011-04-15
Hey Bill, on iOS Titanium.buildDate returns the date in mm/dd/year, while on android its year/mm/dd - is it desirable or necessary for these to return the same format? Other wise this is resolved.
- Thomas Huelbert 2011-04-15
wrong ticket for this comment, pls ignore
- Bill Dawson 2011-04-15
(from [385f47fb6c9f857e2b6e87e1d432242be84acf4b]) [#1358] We were off-by-one when parsing the build hash http://github.com/appcelerator/titanium_mobile/commit/385f47fb6c9f857e2b6e87e1d432242be84acf4b"> http://github.com/appcelerator/titanium_mobile/commit/385f47fb6c9f8...
- Bill Dawson 2011-04-15
I never answered Thomas's earlier question. ... From my perspective it's fine as-is. I was using pre-existing code that we already had for getting the hash, date, etc., and didn't see a need to re-invent the wheel. I mean it's certainly not the only thing that is different between what users see when they build iPhone versus Android. I think it's okay, but if I'm out-voted, let me know. :)
- Bill Dawson 2011-04-15
(from [9ad2e16bf5183ac47c90d9b7501eab7ab784b13c]) [#1358] Also added display of the build version, timestamp and hash at application startup, in the default uncaught handler and the analytics event for exceptions http://github.com/appcelerator/titanium_mobile/commit/9ad2e16bf5183ac47c90d9b7501eab7ab784b13c"> http://github.com/appcelerator/titanium_mobile/commit/9ad2e16bf5183...
- Bill Dawson 2011-04-15
(from [1c05216249dc5a6025ecb0765df9ce023912cedd]) [#1358] Also added display of the build version, timestamp and hash at application startup, in the default uncaught handler and the analytics event for exceptions http://github.com/appcelerator/titanium_mobile/commit/1c05216249dc5a6025ecb0765df9ce023912cedd"> http://github.com/appcelerator/titanium_mobile/commit/1c05216249dc5...
- Bill Dawson 2011-04-15
don, exec. decision req'd, see my October 1st, 2010 @ 04:37 PM comment
- Bill Dawson 2011-04-15
don agreed with me that it's okay as-is. Okay with Thomas to close?
- Thomas Huelbert 2011-04-15
Titanium SDK version: 1.5.0 (12/04/10 08:46 b7b9e78)