[TIMOB-150] Timezone offset should be in minutes, not integral hours (iphone)
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-17T01:52:09.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.1.0 |
| Components | iOS |
| Labels | analytics, ios, ip, iphone |
| Reporter | Daniel Sternbergh |
| Assignee | Blain Hamon |
| Created | 2011-04-15T02:24:23.000+0000 |
| Updated | 2011-04-17T01:52:09.000+0000 |
Description
In version 2 of the analytics event specification, the timezone offset set in the ti.start event should be expressed in minutes. (Currently it is specified in hours.) Unfortunately, not all timezones are integral offsets from UTC. If Newfoundland is insufficient to persuade, then how about India... #:^) Many thanks!
(change is in line 268 of AnalyticsModule.m)
Question to people doing the server side: If I make time zone a float instead of an int, will anything break on the server side?
Not sure, but not sure I understand why making it a float would be desirable (unless to keep it in fractional hours).
not sure if this was completed in 0.7?
did get in to 0.7.0