[TIMOB-1597] [PATCH] TiDomElement.setAttribute not implemented on iPhone
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Trivial |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-17T01:56:37.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.5.0 |
| Components | iOS |
| Labels | iphone, xml |
| Reporter | Brion Vibber |
| Assignee | Reggie Seagraves |
| Created | 2011-04-15T02:57:01.000+0000 |
| Updated | 2011-09-23T06:25:09.000+0000 |
Description
TiDomElement.setAttribute is not implemented on iPhone, though it is implemented on Android.
I've implemented it as I need it for my own code:
http://github.com/brion/titanium_mobile/commits/setattribute">http://github.com/brion/titanium_mobile/commits/setattribute
http://github.com/brion/titanium_mobile/commit/acf88afa6d37c51d20960166cbfae21b10cb0896">
http://github.com/brion/titanium_mobile/commit/acf88afa6d37c51d2096...
Note that numerous other unimplemented methods remain!
Comments
- Brion Vibber 2011-04-15
Assigning open patches from StatusNet to our support contact per request.
- Brion Vibber 2011-04-15
Any issues with this patch? Anyone I should be bringing it to for review?
- Jeff Haynie 2011-04-15
merged.
- Michael Gangolf 2011-09-23
patch isn't working for me:
var win = Titanium.UI.createWindow({});
var text = "
aaa " var xmlDoc = Ti.XML.parseString(text); xmlDoc.documentElement.getElementById('foo0').setAttribute('bar','def'); Ti.API.info(xmlDoc.documentElement.getElementById('foo0').getAttribute("bar")); win.open(); still outputs "abc" and not "def".