[TIMOB-2034] Android: Facebook NPE in FBRequest.generatePostBody if parameter value is null
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Trivial |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2011-04-17T01:57:52.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.5.0 |
| Components | Android |
| Labels | android, defect, rplist |
| Reporter | Bill Dawson |
| Assignee | Bill Dawson |
| Created | 2011-04-15T03:08:42.000+0000 |
| Updated | 2011-04-17T01:57:52.000+0000 |
Description
Customer reported this from a few of its users. The customer is not able to reproduce this, nor am I, so there is no failcase. Here's the trace:
java.lang.NullPointerException
at ti.modules.titanium.facebook.FBRequest.generatePostBody(FBRequest.java:211)
at ti.modules.titanium.facebook.FBRequest.connect(FBRequest.java:341)
at ti.modules.titanium.facebook.FBSession.performRequest(FBSession.java:256)
at ti.modules.titanium.facebook.FBSession.send(FBSession.java:423)
at ti.modules.titanium.facebook.FBRequest.callWithAnyData(FBRequest.java:431)
at ti.modules.titanium.facebook.FBRequest.call(FBRequest.java:381)
at ti.modules.titanium.facebook.FacebookModule.triggerLoginChange(FacebookModule.java:423)
at ti.modules.titanium.facebook.FacebookModule.triggerLogIn(FacebookModule.java:306)
at ti.modules.titanium.facebook.FacebookModule.triggerLogIn(FacebookModule.java:298)
at ti.modules.titanium.facebook.FacebookModule$FBSessionDelegateImpl.sessionDidLogin(FacebookModule.java:431)
at ti.modules.titanium.facebook.FBSession.resume(FBSession.java:374)
at ti.modules.titanium.facebook.FBLoginDialog$FBRequestDelegateImpl.requestDidLoad(FBLoginDialog.java:132)
at ti.modules.titanium.facebook.FBRequest.succeedWithResult(FBRequest.java:306)
at ti.modules.titanium.facebook.FBRequest.handleResponseData(FBRequest.java:286)
at ti.modules.titanium.facebook.FBRequest.connect(FBRequest.java:361)
at ti.modules.titanium.facebook.FBSession.performRequest(FBSession.java:256)
at ti.modules.titanium.facebook.FBSession.send(FBSession.java:423)
at ti.modules.titanium.facebook.FBRequest.post(FBRequest.java:443)
at ti.modules.titanium.facebook.FBLoginDialog.connectToGetSession(FBLoginDialog.java:51)
at ti.modules.titanium.facebook.FBLoginDialog.dialogDidSucceed(FBLoginDialog.java:99)
at ti.modules.titanium.facebook.FBDialog$WebViewClientImpl.shouldOverrideUrlLoading(FBDialog.java:321)
at android.webkit.CallbackProxy.uiOverrideUrlLoading(CallbackProxy.java:216)
at android.webkit.CallbackProxy.handleMessage(CallbackProxy.java:323)
(from [d36f73d4889b205112c0d0f8ba8ab5cc53d8172e]) [#2034 state:fixed-in-qa] Don't call value.getBytes if value is null. This will definitely void the NPE from this ticket, but as we don't have a reproducible failcase we can't really see a before/after http://github.com/appcelerator/titanium_mobile/commit/d36f73d4889b205112c0d0f8ba8ab5cc53d8172e"> http://github.com/appcelerator/titanium_mobile/commit/d36f73d4889b2...
(from [b0304ad9975295c092b957b0730a041855816c4f]) [#2034 state:fixed-in-qa] Don't call value.getBytes if value is null. This will definitely void the NPE from this ticket, but as we don't have a reproducible failcase we can't really see a before/after http://github.com/appcelerator/titanium_mobile/commit/b0304ad9975295c092b957b0730a041855816c4f"> http://github.com/appcelerator/titanium_mobile/commit/b0304ad997529...
as per the ticket, no fail case, closing.